Add trakt.tv provider

[marcuspoehls]

The provider to support the trakt.tv OAuth API is yet missing. This PR helps to add support for trakt.

It uses the extended trakt.tv user profile by default.

Hopefully this helps users to connect with trakt.tv’s OAuth API :)

[ldesplat]

Your own trackt.tv test fails with

Debug: internal, implementation, error 
    Error: Uncaught error: `value` required in setHeader("trakt-api-key", value).
    at ClientRequest.OutgoingMessage.setHeader (_http_outgoing.js:354:11)
    at new ClientRequest (_http_client.js:79:14)
    at Object.exports.request (http.js:31:10)
    at internals.Client.request.options.beforeRedirect.onResponse [as request] 

If you solve that, we can get it merged.

[marcuspoehls]

@ldesplat Ups, sorry. Will check and correct the tests. Thank you

[AdriVanHoudt]

Coverage: 99.94% (1/1601)
lib/providers/trakt.js missing coverage on line(s): 5

missing that 0.06% coverage 😲 😉

[marcuspoehls]

@AdriVanHoudt @ldesplat yeah, I saw the failing tests due to coverage. Can you please tell me how to add test coverage for line 5 in lib/providers/trakt.js?

It's this line:

options = options || {};

in the trakt.js provider.

[AdriVanHoudt]

So you need a test that covers passing options and one that covers it defaulting to {}

[marcuspoehls]

Thank you buddy. I didn’t notice at first what was missing. I thought the default option is fine, but —of course— needs testing as well 😄

[marcuspoehls]

@ldesplat Hi Loïs, I fixed the failing tests and coverage is at 100%. Any chance to get this merged? Thank you!

[AdriVanHoudt]

LGTM

[ldesplat]

Failing tests are normal and nothing to worry about. Just new node globals and we're still on such old versions of our dependencies. Thank you!

[marcuspoehls]

@ldesplat @AdriVanHoudt Thank you for merging!

[lock]

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.