fix regression

hapi-fhir-sql-migrate/src/main/java/ca/uhn/fhir/jpa/migrate/taskdef/BaseTask.java

@@ -211,7 +211,7 @@ private int doExecuteSql(@Language("SQL") String theSql, Object... theArguments)
 			} else {
 				int changesCount = jdbcTemplate.update(theSql, theArguments);
 				logInfo(ourLog, "SQL \"{}\" returned {}", theSql, changesCount);
-				myExecutionResult = MigrationTaskExecutionResultEnum.SUCCESS;
+				myExecutionResult = MigrationTaskExecutionResultEnum.APPLIED;
 				return changesCount;
 			}
 		} catch (DataAccessException e) {
@@ -220,7 +220,7 @@ private int doExecuteSql(@Language("SQL") String theSql, Object... theArguments)
 						"Task {} did not exit successfully on doExecuteSql(), but task is allowed to fail",
 						getMigrationVersion());
 				ourLog.debug("Error was: {}", e.getMessage(), e);
-				myExecutionResult = MigrationTaskExecutionResultEnum.ALLOWED_TO_FAIL;
+				myExecutionResult = MigrationTaskExecutionResultEnum.NOT_APPLIED_ALLOWED_FAILURE;
 				return 0;
 			} else {
 				throw new HapiMigrationException(
@@ -265,13 +265,13 @@ public JdbcTemplate newJdbcTemplate() {
 	public void execute() throws SQLException {
 		if (myFlags.contains(TaskFlagEnum.DO_NOTHING)) {
 			ourLog.info("Skipping stubbed task: {}", getDescription());
-			myExecutionResult = MigrationTaskExecutionResultEnum.SKIPPED;
+			myExecutionResult = MigrationTaskExecutionResultEnum.NOT_APPLIED_SKIPPED;
 			return;
 		}
 		if (!myOnlyAppliesToPlatforms.isEmpty()) {
 			if (!myOnlyAppliesToPlatforms.contains(getDriverType())) {
 				ourLog.info("Skipping task {} as it does not apply to {}", getDescription(), getDriverType());
-				myExecutionResult = MigrationTaskExecutionResultEnum.DOES_NOT_APPLY;
+				myExecutionResult = MigrationTaskExecutionResultEnum.NOT_APPLIED_NOT_FOR_THIS_DATABASE;
 				return;
 			}
 		}
@@ -282,7 +282,7 @@ public void execute() throws SQLException {
 				ourLog.info(
 						"Skipping task since one of the preconditions was not met: {}",
 						precondition.getPreconditionReason());
-				myExecutionResult = MigrationTaskExecutionResultEnum.PRECONDITION_FAILED;
+				myExecutionResult = MigrationTaskExecutionResultEnum.NOT_APPLIED_PRECONDITION_NOT_MET;
 				return;
 			}
 		}

hapi-fhir-sql-migrate/src/main/java/ca/uhn/fhir/jpa/migrate/taskdef/MigrationTaskExecutionResultEnum.java

@@ -4,25 +4,25 @@ public enum MigrationTaskExecutionResultEnum {
 	/**
 	 * Was either skipped via the `skip-versions` flag or the migration task was stubbed
 	 */
-	SKIPPED,
+	NOT_APPLIED_SKIPPED,
 
 	/**
 	 * This migration task does not apply to this database
 	 */
-	DOES_NOT_APPLY,
+	NOT_APPLIED_NOT_FOR_THIS_DATABASE,
 
 	/**
 	 * This migration task had precondition criteria (expressed as SQL) that was not met
 	 */
-	PRECONDITION_FAILED,
+	NOT_APPLIED_PRECONDITION_NOT_MET,
 
 	/**
 	 * The migration failed, but the task has the FAILURE_ALLOWED flag set.
 	 */
-	ALLOWED_TO_FAIL,
+	NOT_APPLIED_ALLOWED_FAILURE,
 
 	/**
-	 * The migration executed successfully
+	 * The migration was applied
 	 */
-	SUCCESS,
+	APPLIED,
 }

hapi-fhir-sql-migrate/src/test/java/ca/uhn/fhir/jpa/migrate/taskdef/ModifyColumnTest.java

@@ -283,7 +283,7 @@ public void testFailureAllowed(Supplier<TestDatabaseDetails> theTestDatabaseDeta
 
 		List<HapiMigrationEntity> entities = myHapiMigrationDao.findAll();
 		assertThat(entities).hasSize(1);
-		assertThat(entities.get(0).getResult()).isEqualTo(MigrationTaskExecutionResultEnum.ALLOWED_TO_FAIL.name());
+		assertThat(entities.get(0).getResult()).isEqualTo(MigrationTaskExecutionResultEnum.NOT_APPLIED_ALLOWED_FAILURE.name());
 	}
 
 	@ParameterizedTest(name = "{index}: {0}")