Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tinder plugin to pluginManagement to allow to run generate-ddl from parent #6192

Merged
merged 14 commits into from
Nov 10, 2024

Conversation

jmarchionatto
Copy link
Collaborator

Added plugin skip option an added plugin to parent project's pom with with skip=true to allow generation to run from parent project.

@jmarchionatto jmarchionatto marked this pull request as draft August 5, 2024 19:49
@jmarchionatto jmarchionatto self-assigned this Aug 5, 2024
Copy link

github-actions bot commented Aug 5, 2024

Formatting check succeeded!

…n postgres dialect precludes to define it at the parent level
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.56%. Comparing base (406db33) to head (5f69d18).
Report is 95 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6192      +/-   ##
============================================
+ Coverage     83.54%   83.56%   +0.02%     
- Complexity    27432    27800     +368     
============================================
  Files          1707     1740      +33     
  Lines        106185   107627    +1442     
  Branches      13397    13502     +105     
============================================
+ Hits          88710    89938    +1228     
- Misses        11750    11893     +143     
- Partials       5725     5796      +71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@tadgh tadgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a changelog, and some docs about how to run it. Otherwise approved.

pom.xml Outdated Show resolved Hide resolved
@jmarchionatto jmarchionatto marked this pull request as ready for review November 10, 2024 14:20
@jmarchionatto jmarchionatto merged commit cdb0a9c into master Nov 10, 2024
66 checks passed
@jmarchionatto jmarchionatto deleted the jm-generate-ddl-from-parent branch November 10, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants