Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to checkstyle #6006

Merged
merged 24 commits into from
Jun 16, 2024
Merged

Add tests to checkstyle #6006

merged 24 commits into from
Jun 16, 2024

Conversation

tadgh
Copy link
Collaborator

@tadgh tadgh commented Jun 13, 2024

  • Add tests to checkstyle
  • Suppress various hamcrest complaints until we fix them
  • Name suppression modules:
    • HapiErrorCodeUniqueness
    • NoPrintln
  • Work on suppressions:
    • unsuppress tests
    • suppress hapi error checker in test files
    • suppress hamcrest complaints in MDM
  • You can now suppress checkstyle warnings on classes/methods by annotating with the ID of the check.
@SuppressWarnings("checkstyle:NoPrintln")

Copy link

github-actions bot commented Jun 13, 2024

Formatting check succeeded!

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.46%. Comparing base (497b9f2) to head (c0626bb).
Report is 95 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6006      +/-   ##
============================================
+ Coverage     83.39%   83.46%   +0.06%     
- Complexity    26927    27237     +310     
============================================
  Files          1681     1697      +16     
  Lines        103965   105320    +1355     
  Branches      13189    13311     +122     
============================================
+ Hits          86702    87902    +1200     
- Misses        11613    11718     +105     
- Partials       5650     5700      +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tadgh tadgh enabled auto-merge (squash) June 15, 2024 18:47
@tadgh tadgh disabled auto-merge June 16, 2024 00:15
@tadgh tadgh merged commit 73a6a8e into master Jun 16, 2024
66 checks passed
@tadgh tadgh deleted the checkstyle-tests branch June 16, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants