-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests to checkstyle #6006
Merged
Merged
Add tests to checkstyle #6006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tadgh
commented
Jun 13, 2024
•
edited
Loading
edited
- Add tests to checkstyle
- Suppress various hamcrest complaints until we fix them
- Name suppression modules:
- HapiErrorCodeUniqueness
- NoPrintln
- Work on suppressions:
- unsuppress tests
- suppress hapi error checker in test files
- suppress hamcrest complaints in MDM
- You can now suppress checkstyle warnings on classes/methods by annotating with the ID of the check.
Formatting check succeeded! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6006 +/- ##
============================================
+ Coverage 83.39% 83.46% +0.06%
- Complexity 26927 27237 +310
============================================
Files 1681 1697 +16
Lines 103965 105320 +1355
Branches 13189 13311 +122
============================================
+ Hits 86702 87902 +1200
- Misses 11613 11718 +105
- Partials 5650 5700 +50 ☔ View full report in Codecov by Sentry. |
tadgh
requested review from
michaelabuckley,
jamesagnew,
fil512 and
AD1306
as code owners
June 14, 2024 21:57
fil512
approved these changes
Jun 15, 2024
hapi-fhir-checkstyle/src/checkstyle/hapi-base-checkstyle-suppression.xml
Show resolved
Hide resolved
...rver-base/src/test/java/ca/uhn/fhir/jaxrs/server/AbstractJaxRsConformanceProviderR4Test.java
Show resolved
Hide resolved
...-test-utilities/src/test/java/ca/uhn/fhir/jpa/provider/r4/ResourceProviderR4ElasticTest.java
Show resolved
Hide resolved
...fhir-jpaserver-mdm/src/test/java/ca/uhn/fhir/jpa/mdm/svc/MdmGoldenResourceMergerSvcTest.java
Show resolved
Hide resolved
hapi-fhir-structures-dstu2/src/test/java/ca/uhn/fhir/util/FhirTerserDstu2Test.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.