Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BaseHapiFhirResourceDao $meta method to use HapiTransactionService instead of @Transaction #5896

Merged
merged 5 commits into from
May 1, 2024
Merged

Fix BaseHapiFhirResourceDao $meta method to use HapiTransactionService instead of @Transaction #5896

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8583cc5
Try making ResourceTable.myTags EAGER instead of LAZY and see if it b…
lukedegruchy Apr 30, 2024
403a5e6
Try making ResourceTable.myTags EAGER instead of LAZY and see if it b…
lukedegruchy Apr 30, 2024
8a73dd0
Ensure BaseHapiFhirResourceDao#metaGetOperation uses HapiTransactionS…
lukedegruchy May 1, 2024
5194184
Add changelog.
lukedegruchy May 1, 2024
4d9b486
Update hapi-fhir-docs/src/main/resources/ca/uhn/hapi/fhir/changelog/7…
lukedegruchy May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...es/ca/uhn/hapi/fhir/changelog/7_2_0/5898-ld-megascale-meta-operation-fails-hapi-0389.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
type: fix
issue: 5898
title: "Previous, triggering a GET $meta on a new patient with Megascale configured resulted in a HAPI-0389.
lukedegruchy marked this conversation as resolved.
Show resolved Hide resolved
This has been fixed."
21 changes: 11 additions & 10 deletions hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/BaseHapiFhirResourceDao.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1410,19 +1410,20 @@ public <MT extends IBaseMetaType> MT metaDeleteOperation(
}

@Override
@Transactional
public <MT extends IBaseMetaType> MT metaGetOperation(Class<MT> theType, IIdType theId, RequestDetails theRequest) {
Set<TagDefinition> tagDefs = new HashSet<>();
BaseHasResource entity = readEntity(theId, theRequest);
for (BaseTag next : entity.getTags()) {
tagDefs.add(next.getTag());
}
MT retVal = toMetaDt(theType, tagDefs);
return myTransactionService.withRequest(theRequest).execute(() -> {
Set<TagDefinition> tagDefs = new HashSet<>();
BaseHasResource entity = readEntity(theId, theRequest);
for (BaseTag next : entity.getTags()) {
tagDefs.add(next.getTag());
}
MT retVal = toMetaDt(theType, tagDefs);

retVal.setLastUpdated(entity.getUpdatedDate());
retVal.setVersionId(Long.toString(entity.getVersion()));
retVal.setLastUpdated(entity.getUpdatedDate());
retVal.setVersionId(Long.toString(entity.getVersion()));

return retVal;
return retVal;
});
}

@Override
Expand Down
Loading