Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug on hapifhirdal searchbyurl to account for version #5087

Merged

Conversation

Capt-Mac
Copy link
Collaborator

Bug fix to account for canonical url's that have version specified.

@Capt-Mac Capt-Mac requested review from JPercival and tadgh as code owners July 13, 2023 16:42
@Capt-Mac Capt-Mac linked an issue Jul 13, 2023 that may be closed by this pull request
@Capt-Mac Capt-Mac requested a review from barhodes July 13, 2023 16:42
@github-actions
Copy link

github-actions bot commented Jul 13, 2023

Formatting check succeeded!

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.77 🎉

Comparison is base (2f5ffe7) 81.32% compared to head (44507b7) 83.10%.

❗ Current head 44507b7 differs from pull request most recent head 6384a75. Consider uploading reports for the commit 6384a75 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5087      +/-   ##
============================================
+ Coverage     81.32%   83.10%   +1.77%     
- Complexity    23650    25663    +2013     
============================================
  Files          1425     1570     +145     
  Lines         86399    99444   +13045     
  Branches      11677    12805    +1128     
============================================
+ Hits          70265    82638   +12373     
- Misses        10947    11282     +335     
- Partials       5187     5524     +337     

see 1578 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lukedegruchy lukedegruchy merged commit d6fae7c into master Jul 14, 2023
@lukedegruchy lukedegruchy deleted the 5086-bug-hapifhirdal-searchbyurl-does-not-parse-version branch July 14, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: HapiFhirDal searchByURL does not parse 'version'
3 participants