Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some comments to the various loincupload.properties for v2.73 #4382

Conversation

KevinDougan
Copy link
Collaborator

Closes #4000

Added some comments to the various loincupload.properties files to clarify that the Hierarchy filename was changed for v2.73.

…s to clarify that the Hierarchy filename was changed for v2.73.
@KevinDougan
Copy link
Collaborator Author

@jmarchionatto
I thought I should at least provide some comments in the hapi-fhir codebase to indicate that the LOINC Hierarchy filename was changed in v2.73.
Could you please approve the addition of these comments in the hopes that it will clarify the situation as described in #4000 ?

@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Base: 81.00% // Head: 81.30% // Increases project coverage by +0.29% 🎉

Coverage data is based on head (071c40e) compared to base (02944ba).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4382      +/-   ##
============================================
+ Coverage     81.00%   81.30%   +0.29%     
- Complexity    23466    23526      +60     
============================================
  Files          1446     1418      -28     
  Lines         86175    86163      -12     
  Branches      11798    11680     -118     
============================================
+ Hits          69809    70057     +248     
+ Misses        11087    10921     -166     
+ Partials       5279     5185      -94     
Impacted Files Coverage Δ
...validation/validator/VersionTypeAdvisorDstu21.java 0.00% <0.00%> (-100.00%) ⬇️
...ir/jpa/provider/r4/BaseResourceProviderR4Test.java 0.00% <0.00%> (-95.32%) ⬇️
...ir/jpa/api/dao/MetadataKeyCurrentlyReindexing.java 40.00% <0.00%> (-60.00%) ⬇️
ca/uhn/fhir/mdm/api/IMdmLink.java 42.85% <0.00%> (-28.58%) ⬇️
...uhn/fhir/jpa/term/config/TermCodeSystemConfig.java 75.00% <0.00%> (-25.00%) ⬇️
...bscription/channel/impl/LinkedBlockingChannel.java 72.72% <0.00%> (-17.28%) ⬇️
...model/entity/ResourceIndexedComboStringUnique.java 56.75% <0.00%> (-16.22%) ⬇️
...hir/rest/server/servlet/ServletRequestDetails.java 73.56% <0.00%> (-15.84%) ⬇️
ca/uhn/fhir/jpa/test/config/TestJPAConfig.java 87.50% <0.00%> (-12.50%) ⬇️
...a/uhn/fhir/jpa/partition/SystemRequestDetails.java 41.30% <0.00%> (-8.70%) ⬇️
... and 276 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@KevinDougan KevinDougan merged commit 155b579 into master Dec 20, 2022
@KevinDougan KevinDougan deleted the 4000-update-loincupload-properties-files-with-comments-for-v273 branch December 20, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loinc Terminology Upload broken with latest version of Loinc 2.73
2 participants