Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add online deferred invalidation keyword for oracle #3409

Merged
merged 3 commits into from
Feb 22, 2022
Merged

add online deferred invalidation keyword for oracle #3409

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b8adadb
add online deferred invalidation keyword for oracle
tadgh Feb 21, 2022
3643553
test
michaelabuckley Feb 22, 2022
4e96089
remove online option from sql server drop index - it can only apply t…
michaelabuckley Feb 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove online option from sql server drop index - it can only apply t… 
…o clustered indices
  • Loading branch information
@michaelabuckley
michaelabuckley committed Feb 22, 2022
commit 4e96089febd0e214ae403f91c92c05a0f6a2c5bd
2 changes: 1 addition & 1 deletion hapi-fhir-sql-migrate/src/main/java/ca/uhn/fhir/jpa/migrate/taskdef/DropIndexTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ List<String> doGenerateSql(boolean isUnique) {
sql.add("drop index " + myIndexName + (myOnline?" ONLINE":""));
break;
case MSSQL_2012:
sql.add("drop index " + getTableName() + "." + myIndexName + (myOnline?" WITH (ONLINE = ON)":""));
sql.add("drop index " + getTableName() + "." + myIndexName );
break;
}
}
Expand Down
5 changes: 1 addition & 4 deletions hapi-fhir-sql-migrate/src/test/java/ca/uhn/fhir/jpa/migrate/taskdef/DropIndexTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
import org.junit.jupiter.params.provider.MethodSource;

import java.sql.SQLException;
import java.util.Arrays;
import java.util.List;
import java.util.function.Supplier;

Expand All @@ -18,9 +17,7 @@
import static org.hamcrest.Matchers.contains;
import static org.hamcrest.Matchers.empty;
import static org.hamcrest.Matchers.equalTo;
import static org.hamcrest.Matchers.hasItem;
import static org.hamcrest.Matchers.not;
import static org.junit.jupiter.api.Assertions.assertEquals;

public class DropIndexTest extends BaseTest {

Expand Down Expand Up @@ -245,7 +242,7 @@ public void onlineNotUnique(DriverTypeEnum theDriver) throws SQLException {
assertThat(mySql, equalTo(asList("drop index IDX_ANINDEX ONLINE")));
break;
case MSSQL_2012:
assertThat(mySql, equalTo(asList("drop index SOMETABLE.IDX_ANINDEX WITH (ONLINE = ON)")));
assertThat(mySql, equalTo(asList("drop index SOMETABLE.IDX_ANINDEX")));
break;
case POSTGRES_9_4:
assertThat(mySql, equalTo(asList("drop index CONCURRENTLY IDX_ANINDEX")));
Expand Down