Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encode narratives of contained resources #3402

Merged
merged 2 commits into from
Feb 17, 2022
Merged

encode narratives of contained resources #3402

merged 2 commits into from
Feb 17, 2022

Conversation

patrick-werner
Copy link
Member

fixes #1466

@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #3402 (f8fab1e) into master (ae33cf8) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3402   +/-   ##
=========================================
  Coverage     82.95%   82.96%           
+ Complexity    20679    20675    -4     
=========================================
  Files          1381     1392   +11     
  Lines         74202    74243   +41     
  Branches      11139    11136    -3     
=========================================
+ Hits          61554    61595   +41     
- Misses         8359     8363    +4     
+ Partials       4289     4285    -4     
Impacted Files Coverage Δ
...e/src/main/java/ca/uhn/fhir/parser/BaseParser.java 84.88% <ø> (-0.06%) ⬇️
...e/src/main/java/ca/uhn/fhir/parser/JsonParser.java 84.15% <ø> (+0.10%) ⬆️
...se/src/main/java/ca/uhn/fhir/parser/XmlParser.java 86.36% <ø> (+0.23%) ⬆️
...n/fhir/jpa/config/HapiFhirHibernateJpaDialect.java 75.00% <0.00%> (-15.63%) ⬇️
...entity/ResourceIndexedSearchParamBaseQuantity.java 95.83% <0.00%> (-1.90%) ⬇️
...uhn/fhir/jpa/dao/FhirResourceDaoValueSetDstu2.java 66.39% <0.00%> (-1.68%) ⬇️
...or/TransactionConcurrencySemaphoreInterceptor.java 83.82% <0.00%> (-1.48%) ⬇️
.../jpa/cache/ResourceChangeListenerRegistryImpl.java 78.37% <0.00%> (-1.11%) ⬇️
...a/model/entity/BaseResourceIndexedSearchParam.java 83.33% <0.00%> (-1.05%) ⬇️
...pa/model/entity/ResourceIndexedSearchParamUri.java 90.90% <0.00%> (-0.88%) ⬇️
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae33cf8...f8fab1e. Read the comment docs.

Copy link
Collaborator

@jamesagnew jamesagnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - Please add a changelog before merge though.

@patrick-werner patrick-werner enabled auto-merge (squash) February 17, 2022 17:29
@patrick-werner patrick-werner merged commit 0c5d868 into master Feb 17, 2022
@patrick-werner patrick-werner deleted the pw/fix-1466 branch February 17, 2022 18:54
michaelabuckley added a commit that referenced this pull request Feb 22, 2022
…oken-search-index

* commit 'fcada390442ee3ada2245f49d62c08cde5212cd7':
  add online deferred invalidation keyword for oracle (#3409)
  GraphQL Introspection Support (#3348)
  Fix parameter count limitation on MSSQL/Oracle large transactions (#3075)
  3400 bulk export rules incorrectly applied to group and patient exports (#3403)
  Use integers for date ordinals (#3346)
  Add license files
  Rel 5 7 mergeback (#3401)
  encode narratives of contained resources (#3402)
  remove hapi jpa spring config hierarchy (#3390)

# Conflicts:
#	hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/dao/r4/FhirResourceDaoR4LuceneDisabledStandardQueries.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creation of a resource removes the narrative from contained resources
2 participants