Email subscription improvements #1535
Open
+486
−112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e with optional parameters to modify how the body of the email gets constructed
… email-subscription-improvements
… email-subscription-improvements # Conflicts: # hapi-fhir-jpaserver-subscription/src/main/java/ca/uhn/fhir/jpa/subscription/module/interceptor/SubscriptionDebugLogInterceptor.java
…m getPayloadId to getResourceId)
|
This pull request introduces 2 alerts when merging e851830 into eb0a657 - view on LGTM.com new alerts:
|
Fixing LGTM errors about boxed boolean variable
… email-subscription-improvements � Conflicts: � hapi-fhir-jpaserver-subscription/src/main/java/ca/uhn/fhir/jpa/subscription/module/subscriber/ResourceDeliveryMessage.java � hapi-fhir-jpaserver-subscription/src/main/java/ca/uhn/fhir/jpa/subscription/module/subscriber/SubscriptionDeliveringRestHookSubscriber.java
|
This pull request fixes 1 alert when merging 4fd3c8d into c3c6796 - view on LGTM.com fixed alerts:
|
|
Hey @seanmcilvenna - The last CI faliure was as a result of a bug unrelated to your change that has been fixed. Can you merge master into your branch once more? |
…e. Otherwise, interceptors can't get the original resource to examine it.
|
This pull request fixes 1 alert when merging 578b9db into 995bda0 - view on LGTM.com fixed alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding interceptors for SUBSCRIPTION_BEFORE_EMAIL_DELIVERY and SUBSCRIPTION_AFTER_EMAIL_DELIVERY
Adding enhancements to email subscriptions to accept a more-complex payload mime-type that includes mime-type options of:
For example: "application/fhir+xml;bodynarrative=true" or "application/fhir+json;bodytext=dGhpcyBpcyBhIHRlc3QgbWVzc2FnZQ=="
When bodynarrative or bodytext is indicated, the resource XML/JSON is added to the email body as an attachment (a second "part" in the multipart body).
These changes are backwards compatible with previous functionality, with the exception that it always creates a multipart message body, even when there is only a plain/simple/empty string for the message body that doesn't have any attachments.