Add .devcontainer to ease onboarding and demo use of Developers #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
choics2623
pushed a commit
to choics2623/LLaVA
that referenced
this pull request
Dec 16, 2023
Add .devcontainer to ease onboarding and demo use of Developers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is non trivial amount of manual setup for running the included Demo and by adding the .devcontainer this becomes automated. This reduces change of human error and enforces consistency.
Video Demonstration
2023-10-30_10-58-16.mp4
I originally thought I would be working more directly on this repo based on talks with @ChunyuanLI so I had done work to add this. It turns out I will be working on something else, but I still wanted to submit the PR in case other researchers find them useful.
I don't expect to work much more on the PR, so feel free to take over the work.
For example, modify the Docker file to remove installation of azcopy or dotnet if you find them irrelevant. Or change postCreateCommand to skip downloading of llava-v1.5-7b