refactor the env setup and install of fastvideo#309
Conversation
0a93c3a to
95d408f
Compare
|
Thank you for the effort! |
95d408f to
4b5b458
Compare
|
I don't like the use of scripts to install flash-attn or sta. I am going to take a look at whether we just put these two dependencies as optional under the |
|
Okay, I checked xDit/xfuers, which depends on flash-attn package, and their instructions in README actually fails if you start with a clean conda env. The best way forward is to add flash-attn instruction in our README if people want to install it and fall back to torch sdpa backend if flash-attn package is not available (already being done) |
agree. Let's do that then. To summarize:
|
|
Yes, I will set the default backend to SDPA in my PR: #312 |
SolitaryThinker
left a comment
There was a problem hiding this comment.
merging to unblock ci/cd work
Co-authored-by: Will Lin <wlsaidhi@gmail.com>
Co-authored-by: Will Lin <wlsaidhi@gmail.com>
Support optional lint install.
Remove sta_attn dependency.
Debug env_setup.py (flash_attn should has wheel preinstalled).