Set up text encoder tests to work with pytest and Github Actions#302
Merged
SolitaryThinker merged 8 commits intohao-ai-lab:mainfrom Apr 2, 2025
Merged
Set up text encoder tests to work with pytest and Github Actions#302SolitaryThinker merged 8 commits intohao-ai-lab:mainfrom
SolitaryThinker merged 8 commits intohao-ai-lab:mainfrom
Conversation
SolitaryThinker
approved these changes
Apr 2, 2025
Collaborator
SolitaryThinker
left a comment
There was a problem hiding this comment.
We might be running in to some consistency issues with secrets. Going to merge and open new PR to test
Collaborator
|
Just seeking clarification: So basically the GPU runner pod is created on-the-fly when a CI job is launched? |
Collaborator
Author
|
@zhisbug When a CI job is launched, the Github "runner" instance that executes the job is created first for free by Github, and then that runner creates the RunPod instance with GPUs which are shut down after the job finishes |
kevin314
added a commit
to kevin314/FastVideo
that referenced
this pull request
Apr 4, 2025
…-ai-lab#302) Co-authored-by: kevin314 <kevin.lin.cs1@gmail.com>
qimcis
pushed a commit
to qimcis/FastVideo
that referenced
this pull request
Oct 30, 2025
…-ai-lab#302) Co-authored-by: kevin314 <kevin.lin.cs1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed test_clip_encoder.py and test_llama.encoder.py to work with pytest:
Usage:
pytest ./fastvideo/v1/tests/test_clip_encoder.py -spytest ./fastvideo/v1/tests/test_llama_encoder.py -sBoth tests:
pytest ./fastvideo/v1/tests/ --ignore=./fastvideo/v1/tests/old_tests/ -sAdded a Github Actions workflow for running tests on PRs with RunPod (only works with the two encoder tests currently):