Conversation
…and enabling default plot settings
…g that caused the relaxation algorithm to produce NaNs. Changed the power balance equation to NOT include P_rad in power balance. Switched to electron density where appropriate. Subtracted Brems. radiation from heating power as per ITER physics basis. Added custom_plot function to add contours. Filled in invalid regions in POPCON plots with gray.
This was referenced Sep 1, 2024
Merged
Tending to NSF example with the new power balance equation.
…book minimally to run functionally
Collaborator
|
This is great stuff @matt-pharr!! Nice work tracking this down! CFSPOPCON also has Synchrotron emission, but we can add that later if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed density and temperature variables for consistency. Fixed a bug that caused the relaxation algorithm to produce NaNs. Changed the power balance equation to NOT include P_rad in power balance. Switched to electron density where appropriate. Subtracted Brems. radiation from heating power as per ITER physics basis. Added custom_plot function to add contours. Filled in invalid regions in POPCON plots with gray. Differentiated between bremsstrahlung and line/impurity radiation.
MANTA example now matches the CFSPOPCON result almost perfectly: