Conversation
Collaborator
Author
|
Re: Close and reopen, it seems we are not eligible for draft pull requests as this is a private repository. |
… between parabolic and loaded profiles
…upport for external profiles.
6d36666 to
4785e46
Compare
…ated plotting settings object.
matt-pharr
commented
Aug 5, 2024
matt-pharr
commented
Aug 5, 2024
src/openpopcon.py
Outdated
| class POPCON_settings: | ||
| """ | ||
| Settings for the POPCON. | ||
| """ |
Collaborator
Author
There was a problem hiding this comment.
This needs to be rewritten to reflect the latest settings. Also need to create a .yaml file for this.
Collaborator
Author
There was a problem hiding this comment.
Will write documentation next pull request
matt-pharr
commented
Aug 5, 2024
Collaborator
Author
|
OpenPOPCON 2.0 beta is ready to merge! Will open issues for remaining improvements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Through the MANTA project, many updates were made to OpenPOPCON that make working with negative triangularity, as well as doing scans and tokamak scoping in general, quite more efficient/effective. These changes are somewhat disparate and sprawling across several different branches on the old repository. Therefore, I am working on a complete refactor of OpenPOPCON. By doing this, I plan to:
New features added by MANTA team members include:
The above items I intend to have completed by EOD July 31 for use in Columbia's new reactor design course.
Additional items I am considering implementing include:
I will post commits here as I work on this project. Feel free to provide feedback, and I hope to request a merge sometime late this month after I post regression tests.