Skip to content

internal PR, all changes combined #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 40 commits into
base: main
Choose a base branch
from
Draft

internal PR, all changes combined #3

wants to merge 40 commits into from

Conversation

@hannojg
Copy link
Owner

@hannojg hannojg commented Dec 5, 2024

Summary:

Changelog:

Test Plan:

hannojg and others added 30 commits December 2, 2024 15:31
@hannojg
add new feature flag for raw jsi values for props
3384d89
@hannojg
wip: first version no std variant
4f1b4e7
@hannojg
use std::variant
fd57139
@hannojg
add new feature flag for raw jsi values for props
65ad0a1
@hannojg
fix problems with JSI RawValue
db983f2
@hannojg
RawPropsParser eventually use RawValue from jsi directly based on fea…
5c70b52 
…ture flag
@hannojg
fix: undefined values are not expected to be in the map
25c2b4b
@hannojg
constructors are expected to be public
95e996a
@hannojg
revert making internal constructors public by moving
94b6575
@hannojg
fix android builds
5ab3b8e
@hannojg @mrousavy
Update packages/react-native/ReactCommon/react/renderer/core/RawValue.h
032674a 
Co-authored-by: Marc Rousavy <marcrousavy@hotmail.com>
@hannojg @mrousavy
Update packages/react-native/ReactCommon/react/renderer/core/RawValue.h
627ce7f 
Co-authored-by: Marc Rousavy <marcrousavy@hotmail.com>
@hannojg @mrousavy
Update packages/react-native/ReactCommon/react/renderer/core/RawValue.h
0b4d071 
Co-authored-by: Marc Rousavy <marcrousavy@hotmail.com>
@hannojg
rename JsiPair -> JsiValuePair
aa3519a
@hannojg
add API to access raw JSI value
79507ed
@hannojg
fix cast to JsiValuePair method
c6e84cb
@hannojg
perf: use emplace + move
490f85e
@hannojg
explicit types
72b7265
@hannojg
cleanup: use as and get jsi values correctly
a05fa9d
@hannojg
use explicit types
f078147
@hannojg
change asX calls to getX as we asserted earlier
3dc5736
@hannojg
remove noexcept as std::get and isNull() can throw
a2fa883
@hannojg
remove untrue doc comment
f7ea9a3
@hannojg
make runtime first arg, jsiValue second
5c7f09d
@hannojg
fix release build add empty return value
7a2aaf2
@hannojg
add assert statement
70a54ee
@hannojg
Merge branch 'main' of github.com:facebook/react-native into feat/jsi…
7b9f817 
…-value-raw-value-props
@hannojg
Update feature flags after merge
7926707
@hannojg
update changelog
d3a332f
@hannojg
Revert "update changelog"
a82f082 
This reverts commit d3a332f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hannojg