Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Water hydras cause two Rare Sea Creature popups #749

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

brandonwamboldt
Copy link
Contributor

Also added shadows to sendTitle because it makes it more legible, titles can be hard to see against certain backgrounds. Allowed for customizable font size on titles too, current default matches previous behavior.

/shsendtitle can be used to test, like this:

/shsendtitle 3 2.8 7 Legendary Catch!

javaw_2023-12-01_08-57-38

Font size is still scaled by the number of characters in the text so it still scales properly on screen sizes, fontSize is proportional.

@hannibal002 hannibal002 added this to the Version 0.22 milestone Dec 1, 2023
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Dec 1, 2023
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Dec 4, 2023
Copy link

github-actions bot commented Dec 4, 2023

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@hannibal002 hannibal002 self-requested a review December 8, 2023 15:24
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/config/commands/Commands.kt
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Dec 8, 2023
Copy link

github-actions bot commented Dec 8, 2023

Conflicts have been resolved! 🎉

@hannibal002 hannibal002 merged commit 4fa9b95 into hannibal002:beta Dec 8, 2023
2 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants