Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Item with no UUID do not show cooldown correctly #508

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

brandonwamboldt
Copy link
Contributor

Fix an issue where items with no UUID won't correctly show their cooldown, and where some items may incorrectly show a cooldown when there isnt one.

If no UUID or ID is present on the item, don't check it for cooldowns.

@hannibal002 hannibal002 added this to the Version 0.20 milestone Sep 27, 2023
@hannibal002 hannibal002 self-requested a review September 27, 2023 10:37
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you forgotten to commit changes in SkyBlockItemModifierUtils.kt ?
image

@hannibal002
Copy link
Owner

Found the method in #509, nevermind!

@hannibal002 hannibal002 merged commit fe21cf0 into hannibal002:beta Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants