Fix: Hide Other Players in Dance Room Helper not updating if disabled #3413
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixed the "Hide Other Players" option in Dance Room Helper not being properly respected if the main "Enabled" switch is off. (
inRoom
was not being updated, so it could also result in players being hidden outside the Mirrorverse.)Also some small code refactors, using
onlyInIsland
as well as adding aRealPlayer
check just in case, though it is not strictly necessary with the main bugfix, as we don't need to show any entities in the Dance Room. (I've confirmed that the mirrored players are also detected asRealPlayer
.)Changelog Fixes