Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Hide Other Players in Dance Room Helper not updating if disabled #3413

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

lunaynx
Copy link
Contributor

@lunaynx lunaynx commented Feb 10, 2025

What

Fixed the "Hide Other Players" option in Dance Room Helper not being properly respected if the main "Enabled" switch is off. (inRoom was not being updated, so it could also result in players being hidden outside the Mirrorverse.)

Also some small code refactors, using onlyInIsland as well as adding a RealPlayer check just in case, though it is not strictly necessary with the main bugfix, as we don't need to show any entities in the Dance Room. (I've confirmed that the mirrored players are also detected as RealPlayer.)

Changelog Fixes

  • Fixed "Hide Other Players" in Dance Room Helper not working when the helper is disabled. - Luna
  • Fixed players and some mobs being hidden outside the Mirrorverse when "Hide Other Players" is enabled in Dance Room Helper. - Luna

@github-actions github-actions bot added the Bug Fix Bug fixes label Feb 10, 2025
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about we also check if the player is in the mirror verse everywhre, not only if in the dance room? so that we dont need to check if in dance room everytime while in rift?

@hannibal002
Copy link
Owner

Also the isEnabled() functio can now be removed as its only containing one check

@lunaynx lunaynx requested a review from hannibal002 February 10, 2025 15:42
@hannibal002 hannibal002 added this to the 2.0.0 milestone Feb 10, 2025
@hannibal002 hannibal002 merged commit 4bdd4f0 into hannibal002:beta Feb 11, 2025
6 checks passed
@github-actions github-actions bot removed the Bug Fix Bug fixes label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants