Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: Storage Needs @Expose #3292

Merged

Conversation

DavidArthurCole
Copy link
Contributor

@DavidArthurCole DavidArthurCole commented Jan 24, 2025

What

Follow-up on #3203, a functional version that'll play well with nea's PR #3285 (but not dependent on it).

Images

image

Changelog Technical Details

  • Added detekt rule to prevent @Expose from being removed during merges. - Daveed

@github-actions github-actions bot added Backend A backend pull request that will be merged soon Wrong Title/Changelog There is an error in the title or changelog labels Jan 24, 2025
Copy link

I have detected some issues with your pull request:

Body issues:
Author is not set in text: + Added detekt rule to prevent @expose from being removed during merges.
Unexpected empty line after category declared

Please fix these issues. For the correct format, refer to the pull request template.

Copy link

I have detected some issues with your pull request:

Title issues:
PR title does not match the expected format of 'Category: Title'

Please fix these issues. For the correct format, refer to the pull request template.

@DavidArthurCole DavidArthurCole changed the title Backend; Storage Needs @Expose Backend: Storage Needs @Expose Jan 24, 2025
@github-actions github-actions bot removed the Wrong Title/Changelog There is an error in the title or changelog label Jan 24, 2025
@hannibal002 hannibal002 added this to the Version 2.0.0 milestone Jan 24, 2025
@hannibal002 hannibal002 enabled auto-merge (squash) January 24, 2025 17:52
@hannibal002 hannibal002 merged commit 4ee8349 into hannibal002:beta Jan 24, 2025
6 checks passed
@github-actions github-actions bot removed the Backend A backend pull request that will be merged soon label Jan 24, 2025
@DavidArthurCole DavidArthurCole deleted the ExposeInConfigAndStorage branch January 24, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants