Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: Repo Patterns BazaarAPI #3271

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Backend: Repo Patterns BazaarAPI #3271

merged 3 commits into from
Jan 24, 2025

Conversation

hannibal002
Copy link
Owner

@hannibal002 hannibal002 commented Jan 23, 2025

What

Using repo patterns in BazaarAPI and renamed the class.

Changelog Technical Details

  • Implemented REPO patterns in BazaarAPI. - hannibal2
    • Improved maintainability.

@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Jan 23, 2025
@hannibal002 hannibal002 added this to the Version 2.0.0 milestone Jan 23, 2025
@hannibal002 hannibal002 requested a review from CalMWolfs January 23, 2025 22:36
@github-actions github-actions bot added Backend A backend pull request that will be merged soon Merge Conflicts There are open merge conflicts with the beta branch. labels Jan 23, 2025
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/features/inventory/bazaar/BazaarAPI.kt
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 24, 2025
Copy link

Conflicts have been resolved! 🎉

@hannibal002 hannibal002 merged commit c9fac1f into beta Jan 24, 2025
11 checks passed
@github-actions github-actions bot removed Soon This Pull Request will be merged within the next couple of betas Backend A backend pull request that will be merged soon labels Jan 24, 2025
@CalMWolfs CalMWolfs deleted the backend-bz-repo-pattern branch January 26, 2025 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants