Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: EstimatedItemValueCalculator cleanup #3255

Merged
merged 21 commits into from
Jan 21, 2025

Conversation

hannibal002
Copy link
Owner

@hannibal002 hannibal002 commented Jan 19, 2025

What

Using getTotalAndNames() to cleanup all lists in estimated item value logic
Using formatWithBrackets to avoid duplicate bracket formattings
using formatProgress() to avoid duplicate x/y (price) lines
Using formatHaving() to avoid duplicate name: check (price) lines

Changelog Technical Details

  • Cleaned up estimated item value logic. - hannibal2

@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Jan 19, 2025
@hannibal002 hannibal002 added this to the Version 2.0.0 milestone Jan 19, 2025
@github-actions github-actions bot added the Backend A backend pull request that will be merged soon label Jan 19, 2025
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 19, 2025
@hannibal002 hannibal002 changed the title Backend: EstimatedItemValueCalculator getTotalAndNames Backend: EstimatedItemValueCalculator cleanup Jan 19, 2025
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/features/misc/items/EstimatedItemValueCalculator.kt
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 19, 2025
@hannibal002 hannibal002 merged commit 557c24b into beta Jan 21, 2025
11 checks passed
@github-actions github-actions bot removed Soon This Pull Request will be merged within the next couple of betas Backend A backend pull request that will be merged soon labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant