Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Overflow levelups no longer hardcoded #3177

Merged
merged 7 commits into from
Jan 8, 2025

Conversation

KeinsWolfi
Copy link
Contributor

@KeinsWolfi KeinsWolfi commented Jan 7, 2025

Fix: Overflow levelups no longer hardcoded so they now appear correctly

What

Fixes Overflow levelup messages only appearing when above Level 60, even if the max level of the skill is not 60

Changelog Fixes

  • Fixed overflow skill level-up messages only appearing above level 60. - Helium9

Fix: Overflow levelups no longer hardcoded so they now appear correctly
@github-actions github-actions bot added the Bug Fix Bug fixes label Jan 7, 2025
@KeinsWolfi KeinsWolfi marked this pull request as ready for review January 7, 2025 19:11
@hannibal002
Copy link
Owner

We decided against this, since this could confuse greatly for taming and farming.

@lunaynx
Copy link
Contributor

lunaynx commented Jan 8, 2025

This changes nothing for Taming and Farming.

@KeinsWolfi
Copy link
Contributor Author

I will try to fix taming and farming (I mainly intended the fix for levels with a hard cap at 50)

@hannibal002
Copy link
Owner

This changes nothing for Taming and Farming.

Do we assume the player already has a max cap of 60 for taming and farming?

Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apparently we do

@hannibal002 hannibal002 merged commit f276ffb into hannibal002:beta Jan 8, 2025
6 checks passed
@github-actions github-actions bot removed the Bug Fix Bug fixes label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants