Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backend: Fix NeuInternalName.equals #2870

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Backend: Fix NeuInternalName.equals #2870

merged 1 commit into from
Nov 1, 2024

Conversation

hannibal002
Copy link
Owner

@hannibal002 hannibal002 commented Oct 31, 2024 •
edited
Loading

What

Fixes all calls of NeuInternalName.equals

Changelog Technical Details

  • Usages of 'equals' have been significantly reduced. - hannibal2

@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Oct 31, 2024
@hannibal002 hannibal002 added this to the Version 0.28 milestone Oct 31, 2024
@hannibal002 hannibal002 requested a review from CalMWolfs October 31, 2024 17:01
@github-actions github-actions bot added the Backend A backend pull request that will be merged soon label Oct 31, 2024
@hannibal002
Copy link
Owner Author

Also this replaces #2869

CalMWolfs
CalMWolfs approved these changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@hannibal002 hannibal002 merged commit 4b6517a into beta Nov 1, 2024
15 checks passed
@github-actions github-actions bot removed Soon This Pull Request will be merged within the next couple of betas Backend A backend pull request that will be merged soon labels Nov 1, 2024
@jani270 jani270 deleted the cleanup-neu-internal-name-equals branch January 6, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalMWolfs CalMWolfs CalMWolfs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0 (old Version 0.28)
Development

Successfully merging this pull request may close these issues.
2 participants
@hannibal002 @CalMWolfs