-
-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement: Add option to only hide sack changes while in the garden #2858
Conversation
I have detected some issues with your pull request: Body issues: Please fix these issues. For the correct format, refer to the pull request template. |
Made requested changes, I've tested this and it works |
src/main/java/at/hannibal2/skyhanni/config/features/chat/ChatConfig.java
Outdated
Show resolved
Hide resolved
Co-authored-by: CalMWolfs <94038482+CalMWolfs@users.noreply.github.com>
One or more Detekt Failures were detected:
|
One or more Detekt Failures were detected:
|
Any issues left with this PR? It would be nice to have this in before 0.29, it's fairly simple. |
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surely we can get a soon on this
Conflicts have been resolved! 🎉 |
One or more Detekt Failures were detected:
|
i think my fix broke something? |
What
Adds an option to only hide sack change messages while in the garden. Requested in this suggestion
Changelog Improvements