Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Add option to only hide sack changes while in the garden #2858

Merged
merged 13 commits into from
Jan 25, 2025

Conversation

MisterCheezeCake
Copy link
Contributor

@MisterCheezeCake MisterCheezeCake commented Oct 29, 2024

What

Adds an option to only hide sack change messages while in the garden. Requested in this suggestion

Changelog Improvements

  • Added option to only hide sack messages while in the garden. - MisterCheezeCake

@github-actions github-actions bot added the Wrong Title/Changelog There is an error in the title or changelog label Oct 29, 2024
Copy link

I have detected some issues with your pull request:

Body issues:
Change should start with 'Added' instead of 'Add' in text: Add option to only hide sack messages while in the garden.

Please fix these issues. For the correct format, refer to the pull request template.

@CalMWolfs CalMWolfs added this to the Version 0.29 milestone Oct 29, 2024
@MisterCheezeCake
Copy link
Contributor Author

Made requested changes, I've tested this and it works

@github-actions github-actions bot removed the Wrong Title/Changelog There is an error in the title or changelog label Oct 30, 2024
MisterCheezeCake and others added 2 commits October 30, 2024 08:40
Co-authored-by: CalMWolfs <94038482+CalMWolfs@users.noreply.github.com>
Copy link

One or more Detekt Failures were detected:

Copy link

One or more Detekt Failures were detected:

@lunaynx
Copy link
Contributor

lunaynx commented Nov 25, 2024

Any issues left with this PR? It would be nice to have this in before 0.29, it's fairly simple.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

Copy link
Contributor

@j10a1n15 j10a1n15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surely we can get a soon on this

Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 25, 2025
@github-actions github-actions bot added the Detekt Has detekt problem label Jan 25, 2025
Copy link

One or more Detekt Failures were detected:

  • DataWatcherAPI.kt#L1: File 'DataWatcherAPI.kt' contains a single top level declaration and should be named 'DataWatcherApi.kt'
  • DataWatcherAPI.kt#L26: The file name 'DataWatcherAPI' does not match the name of the single top-level declaration 'DataWatcherApi'.
  • DataWatcherAPI.kt#L51: The loop contains more than one break or continue statement. The code should be refactored to increase readability.

@hannibal002
Copy link
Owner

i think my fix broke something?

@CalMWolfs CalMWolfs enabled auto-merge (squash) January 25, 2025 21:10
@CalMWolfs CalMWolfs added the Soon This Pull Request will be merged within the next couple of betas label Jan 25, 2025
@github-actions github-actions bot removed the Detekt Has detekt problem label Jan 25, 2025
@CalMWolfs CalMWolfs merged commit 86a3090 into hannibal002:beta Jan 25, 2025
6 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Jan 25, 2025
@hannibal002 hannibal002 changed the title Feature: Add option to only hide sack changes while in the garden Improvement: Add option to only hide sack changes while in the garden Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants