Skip to content
  • Rate limit · GitHub

    Access has been restricted

    You have triggered a rate limit.

    Please wait a few minutes before you try again;
    in some cases this may take up to an hour.

  • Notifications You must be signed in to change notification settings
  • Fork 216
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: SpecialColor translation #2854

Merged
merged 23 commits into from
Nov 22, 2024

Conversation

j10a1n15
Copy link
Contributor

@j10a1n15 j10a1n15 commented Oct 28, 2024

What

This Pull Request translates to kotlin and improves the SpecialColor.java file.
It also moves code that still use the old specialToChromaRGB() method to the updated one.

Changelog Technical Details

  • Translated SpecialColor to Kotlin. - j10a1n15
  • Deprecated ColorUtils.toChromaColor() methods and moved them to SpecialColor. - j10a1n15

Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
@github-actions github-actions bot added the Backend A backend pull request that will be merged soon label Oct 28, 2024
Copy link

One or more Detekt Failures were detected:

@hannibal002 hannibal002 added this to the Version 0.29 milestone Oct 28, 2024
Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
Copy link

One or more Detekt Failures were detected:

Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
Copy link

One or more Detekt Failures were detected:

Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
Copy link

One or more Detekt Failures were detected:

Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
Copy link

One or more Detekt Failures were detected:

Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
Copy link

One or more Detekt Failures were detected:

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Nov 1, 2024
Copy link

github-actions bot commented Nov 1, 2024

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

Copy link

github-actions bot commented Nov 1, 2024

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Nov 1, 2024
… object

Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
@github-actions github-actions bot added the Wrong Title/Changelog There is an error in the title or changelog label Nov 15, 2024
Copy link

I have detected some issues with your pull request:

Body issues:
Author is not set in text: + Deprecated ColorUtils' toChromaColor() methods and move them to SpecialColor. + j10a1n15
Change should end with a full stop in text: Deprecated ColorUtils' toChromaColor() methods and move them to SpecialColor. + j10a1n15

Please fix these issues. For the correct format, refer to the pull request template.

Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
@github-actions github-actions bot added Detekt Has detekt problem and removed Wrong Title/Changelog There is an error in the title or changelog labels Nov 15, 2024
Copy link

One or more Detekt Failures were detected:

@github-actions github-actions bot removed the Detekt Has detekt problem label Nov 15, 2024
@github-actions github-actions bot added the Detekt Has detekt problem label Nov 19, 2024
Copy link

One or more Detekt Failures were detected:

Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Nov 20, 2024
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/features/minion/MinionFeatures.kt
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Nov 20, 2024
Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
@github-actions github-actions bot removed the Detekt Has detekt problem label Nov 20, 2024
@CalMWolfs CalMWolfs modified the milestones: Version 0.29, Version 0.28 Nov 22, 2024
@CalMWolfs CalMWolfs enabled auto-merge (squash) November 22, 2024 02:13
@CalMWolfs CalMWolfs merged commit f411297 into hannibal002:beta Nov 22, 2024
6 checks passed
@github-actions github-actions bot removed the Backend A backend pull request that will be merged soon label Nov 22, 2024
@j10a1n15 j10a1n15 deleted the backend/specialcolor branch November 22, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rate limit · GitHub

Access has been restricted

You have triggered a rate limit.

Please wait a few minutes before you try again;
in some cases this may take up to an hour.

3 participants