Backend: Detekt Fixes Part 8 #2734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Backend
|
I have detected some issues with your pull request: Body issues: Please fix these issues. For the correct format, refer to the pull request template. |
github-actions
bot
removed
the
Wrong Title/Changelog
|
There's seemingly an issue with specifically 1.12.2 detekt running and failing in the multi version build. Will look into this... |
github-actions
bot
added
the
Merge Conflicts
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
github-actions
bot
removed
the
Merge Conflicts
|
Conflicts have been resolved! 🎉 |
CalMWolfs
added
the
Soon
CalMWolfs
approved these changes
Oct 15, 2024
github-actions
bot
added
the
Merge Conflicts
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
|
Conflicts have been resolved! 🎉 |
github-actions
bot
removed
the
Merge Conflicts
github-actions
bot
removed
the
Soon
github-actions
bot
removed
the
Backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes all instances of ALL detektions, including regressions since the
HEADs of #2667 and #2657. Mainly the following:CustomCommentSpacing(regression)AvoidBritishSpelling(regression)CyclomaticComplexMethodLargeClass(regression)LongMethod(regression)PrintStackTrace(regression)ImportOrdering/NoUnusedImportsIndentation(regression)NoMultipleSpaces(regression)NoTrailingSpaces(regression)PropertyWrapping(regression)SpacingAroundKeyword(regression)StringTemplate(regression)Wrapping(regression)FunctionNamingFunctionParameterNamingMemberNameEqualsClassName(regression)ObjectPropertyNamingArrayPrimitive(regression)ForEachOnRangeSpreadOperatorIteratorNotThrowingNoSuchElementExceptionMapGetWithNotNullAssertionOperatorDestructuringDeclarationWithTooManyEntriesMaxLineLength(regression)ReturnCount(regression)UnusedParameterUnusedPrivatePropertyUseAnyOrNoneInsteadOfFind(regression)UseOrEmpty- Main factor, 114 detektions at HEADUtilityClassWithPublicConstructorVarCouldBeValDetektion count down to 0 from 261 at HEAD.
This PR also enables
detektrunning during the build process, anddetektMainrunning during the Pull Request build process. If/when this gets merged, detekt will be fully enabled.Changelog Technical Details
groupOrEmptytoMatchMatcher. - DaveedgroupOrNull("[group]").orEmpty()