Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Rabbit the Fish GUI Close Blocker #2712

Merged
merged 6 commits into from
Oct 16, 2024

Conversation

DavidArthurCole
Copy link
Contributor

@DavidArthurCole DavidArthurCole commented Oct 10, 2024

What

Adds a config option for blocking closure of the Meal Egg UI if Rabbit the Fish is present.
Also moved the Warp Menu stuff into its own accordion since there was more than one slider for the same feature-set.

Changelog New Features

  • Added the ability to prevent closing Meal Eggs that have Rabbit the Fish inside. - Daveed

Changelog Technical Details

  • Moved Hoppity Warp Menu config to HoppityWarpMenuConfig. - Daveed

@CalMWolfs CalMWolfs added this to the Version 0.28 milestone Oct 11, 2024
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Oct 12, 2024
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could not test in game, but code looks good

@hannibal002 hannibal002 merged commit e2f7293 into hannibal002:beta Oct 16, 2024
4 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Oct 16, 2024
@DavidArthurCole DavidArthurCole deleted the FishTheRabbitGUI branch October 16, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants