-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Rabbit the Fish GUI Close Blocker #2712
Merged
hannibal002
merged 6 commits into
hannibal002:beta
from
DavidArthurCole:FishTheRabbitGUI
Oct 16, 2024
Merged
Feature: Rabbit the Fish GUI Close Blocker #2712
hannibal002
merged 6 commits into
hannibal002:beta
from
DavidArthurCole:FishTheRabbitGUI
Oct 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannibal002
added
the
Soon
This Pull Request will be merged within the next couple of betas
label
Oct 12, 2024
CalMWolfs
requested changes
Oct 15, 2024
src/main/java/at/hannibal2/skyhanni/features/event/hoppity/HoppityRabbitTheFishChecker.kt
Outdated
Show resolved
Hide resolved
CalMWolfs
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
hannibal002
requested changes
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could not test in game, but code looks good
src/main/java/at/hannibal2/skyhanni/mixins/transformers/gui/MixinGuiContainer.java
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/event/hoppity/HoppityRabbitTheFishChecker.kt
Outdated
Show resolved
Hide resolved
hannibal002
approved these changes
Oct 16, 2024
github-actions
bot
removed
the
Soon
This Pull Request will be merged within the next couple of betas
label
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds a config option for blocking closure of the Meal Egg UI if Rabbit the Fish is present.
Also moved the Warp Menu stuff into its own accordion since there was more than one slider for the same feature-set.
Changelog New Features
Changelog Technical Details
HoppityWarpMenuConfig
. - Daveed