Feature: Notify when a player join/leave your lobby #2653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/java/at/hannibal2/skyhanni/config/features/markedplayer/MarkedPlayerConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/config/features/markedplayer/MarkedPlayerConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/config/features/markedplayer/MarkedPlayerConfig.java
Outdated
Show resolved
Hide resolved
…er/MarkedPlayerConfig.java Co-authored-by: martimavocado <39881008+martimavocado@users.noreply.github.com>
…er/MarkedPlayerConfig.java Co-authored-by: martimavocado <39881008+martimavocado@users.noreply.github.com>
…er/MarkedPlayerConfig.java Co-authored-by: martimavocado <39881008+martimavocado@users.noreply.github.com>
CalMWolfs
requested changes
Oct 8, 2024
| public Property<String> playersList = Property.of("hypixel,Minikloon"); | ||
|
|
||
| @Expose | ||
| @ConfigOption(name = "Use Prefix", desc = "Should the [SkyHanni] prefix should be in the join/leave message ?") |
There was a problem hiding this comment.
The formatting around the question mark is incorret
…SkyHanni into trackedplayer-joinleave
CalMWolfs
changed the title
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
github-actions
bot
added
the
Merge Conflicts
…leave # Conflicts: # src/main/java/at/hannibal2/skyhanni/features/misc/MarkedPlayerManager.kt
|
Conflicts have been resolved! 🎉 |
github-actions
bot
removed
the
Merge Conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Previously:
Notify you when a marked player join or leave your lobby.
Changelog New Features