Backend: Add multi version preprocessor

[nea89o]

PR Reviews

When your PR is marked as ready for review, some of our maintainers will look through your code to make sure everything is good to go. In order to do this, they may request some changes you will need to do, or fix smaller stuff (like merge conflicts) for you. If a maintainer has reviewed your PR, make sure to pull any of their changes into your local project before doing more work on your code. Having maintainers fix small stuff for you helps us speed up the process of merging your PR, so if some of your systems warrant further care, be sure to let us know (preferably with a code comment).

Make sure to only mark your PR as "Ready to review" when it is. If you still want to do major changes, you can keep a draft PR open until then.

What

This PR adds a preprocessor to automatically remap all skyhanni code to 1.21. This does not work, of course. The remapped sources are full of problems: Some methods have different names whose conversion gets lost between versions. Some methods simply get called with different arguments and need to manually handled. Some methods get fully removed and new workarounds need to be written.

The goal of this PR is to have a way for contributors to slowly make features they write work on 1.21 over time to ease the burden when making the final jump. It should run in the background and not halt normal development.

Check out the CONTRIBUTING.md changes for more info.

Changelog Technical Details

• Added a preprocessor to prepare for 1.21. - !nea
  • This will require a minor adjustment in how the Minecraft client is launched.

[github-actions]

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

[nea89o]

I am going to assume that the conflict here is the version number only and am not going to fix the conflict therefore. Unless you wanna make bigger changes you should probably just discard the changes and edit the version number directly in the new branch

[github-actions]

Conflicts have been resolved! 🎉

[nea89o]

i didnt mean for you to fix it i just meant that i didnt feel like fixing it for every version update lol

[hannibal002]

I intend to merge this pr before the next beta version

[btwonion]

Hi,
in the Contributing document you described the processing of the mappings very extensively.
But how do you plan to replace the forge libraries? The main problem here is the event system I suppose - are you planning to replace it completely for a standalone system?

[nea89o]

For the event library there is already a replacement system existing that is planned to be used in 1.8.9 as well. For the other forge functions we'll need to write custom functions as well using preprocessor directives like for other missing minecraft functions.

[btwonion]

ah I see. great. I'm looking forward to the porting process.

[hannibal002]

this reminds me, we need to readdress the event bus system and finally move over to the new system globally (after fixed all remaining problems with it)

[hannibal002]

After running this in dev env, ive found two bugs:

They happened when running the 1.8.9 runClient script. I am not sure if this is related, though.

shaders are broken in custom scoreboard

SkyHanni 0.26.Beta.21: Caught an ExceptionInInitializerError in CustomScoreboard at GuiOverlayRenderEvent: null
 
Caused by java.lang.ExceptionInInitializerError: null
at SH.utils.RenderUtils.drawRoundRect(RenderUtils.kt:1785)
at SH.utils.RenderUtils.drawRoundRect$default(RenderUtils.kt:1778)
at SH.features.gui.customscoreboard.RenderBackground.renderBackground(RenderBackground.kt:60)
at SH.features.gui.customscoreboard.CustomScoreboard.onRenderOverlay(CustomScoreboard.kt:61)
at SH.data.RenderData.onRenderOverlay(RenderData.kt:31)
at FML.common.eventhandler.EventBus.post(EventBus.java:140)
Caused by java.io.FileNotFoundException: skyhanni:shaders/rounded_rect.vsh
at MC.client.resources.SimpleReloadableResourceManager.getResource(SimpleReloadableResourceManager.java:68)
at SH.utils.shader.ShaderManager.loadShader(ShaderManager.kt:67)
at SH.utils.shader.Shader.recompile(Shader.kt:59)
at SH.utils.shader.Shader.<init>(Shader.kt:31)
at SH.features.misc.RoundedShader.<init>(RoundedShader.kt:7)
at SH.features.misc.RoundedRectangleShader.<init>(RoundedShader.kt:27)
at SH.features.misc.RoundedRectangleShader.<clinit>(RoundedShader.kt)
at SH.utils.RenderUtils.drawRoundRect(RenderUtils.kt:1785)
at SH.utils.RenderUtils.drawRoundRect$default(RenderUtils.kt:1778)
at SH.features.gui.customscoreboard.RenderBackground.renderBackground(RenderBackground.kt:60)
at SH.features.gui.customscoreboard.CustomScoreboard.onRenderOverlay(CustomScoreboard.kt:61)
at SH.data.RenderData.onRenderOverlay(RenderData.kt:31)
at FML.common.eventhandler.EventBus.post(EventBus.java:140)

Skull texture gets rendered weirdly wrong

[ItsEmpa]

the skull being rendered wrong is because of the same shaders bug

[nea89o]

Looks like it's just forge not finding the resources because they are not in the kotlin classes directory. Forgot it is like that on 1.8.9. As for the runClient: the runClient gradle task should work but I'll also make it generate a regular intellij config again (Although it should be noted that the intellij task does not seem manual set up to work with the right java version, unlike the gradle task)

[pauliesnug]

looks gay to me!!!!!! :3 /pos

[github-actions]

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

[github-actions]

Conflicts have been resolved! 🎉