Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Attribute Overlay #2001

Merged
merged 28 commits into from
Oct 22, 2024

Conversation

ItsEmpa
Copy link
Contributor

@ItsEmpa ItsEmpa commented Jun 4, 2024

Dependencies

What

Adds an overlay for showing attributes of items and their levels, being able to customize which attributes to show, and being able to highlight godrolls in a different color.

Images

image

Changelog New Features

  • Added Attribute Overlay. - Empa
    • Options to highlight good rolls in different colors, show only certain attributes, etc.

Signed-off-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
Signed-off-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
Signed-off-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
Copy link

github-actions bot commented Jun 9, 2024

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Jun 9, 2024
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/config/features/inventory/InventoryConfig.java
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Jun 10, 2024
Signed-off-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
Signed-off-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
Signed-off-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
Signed-off-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
@ItsEmpa ItsEmpa marked this pull request as ready for review June 28, 2024 18:20
Signed-off-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
Signed-off-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
This reverts commit 9ecf260.
Signed-off-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
@hannibal002 hannibal002 added this to the Version 0.27 milestone Jun 29, 2024
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Jun 30, 2024
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/config/features/inventory/InventoryConfig.java
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Jul 25, 2024
Copy link

Conflicts have been resolved! 🎉

@hannibal002 hannibal002 modified the milestones: Version 0.27, Version 0.28 Sep 7, 2024
Copy link

github-actions bot commented Sep 7, 2024

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Sep 7, 2024
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/config/features/inventory/InventoryConfig.java
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Sep 11, 2024
Copy link

Conflicts have been resolved! 🎉

Signed-off-by: ItsEmpa <itsempa@users.noreply.github.com>
@jani270 jani270 added the Soon This Pull Request will be merged within the next couple of betas label Oct 8, 2024
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be good if these had some colour i think, looks a little bland
image

Hide non Good Rolls does not work for me

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Oct 18, 2024
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@hannibal002 hannibal002 added test and removed test labels Oct 18, 2024
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Oct 22, 2024
Copy link

Conflicts have been resolved! 🎉

@hannibal002 hannibal002 merged commit 4e03682 into hannibal002:beta Oct 22, 2024
5 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Oct 22, 2024
@ItsEmpa ItsEmpa deleted the feature/attribute-overlay branch October 25, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants