Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Flare Display #1803

Merged
merged 12 commits into from
May 24, 2024
Merged

Feature: Flare Display #1803

merged 12 commits into from
May 24, 2024

Conversation

superhize
Copy link
Contributor

@superhize superhize commented May 16, 2024 •
edited by hannibal002
Loading

What

SOS, Alert and Warning flare display.

Images

direct

Changelog New Features

  • SOS/Alert/Warning Flare Display. - HiZe + hannibal2
    • Warn when the flare is about to despawn (chat, title or both).
    • Change the display type (as a GUI element, in the world, or both).
    • Show effective area (as a wireframe, filled or circle).
    • Show mana regeneration buff next to the GUI element.
    • Option to hide flare particles.

@hannibal002 hannibal002 added this to the Version 0.26 milestone May 16, 2024
CalMWolfs
CalMWolfs requested changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just this one change, the rest of the code looks fine

src/main/java/at/hannibal2/skyhanni/config/features/misc/FlareConfig.java Outdated Show resolved Hide resolved
@superhize @CalMWolfs
Update src/main/java/at/hannibal2/skyhanni/config/features/misc/Flare…
02eee0f 
…Config.java


Suggested change

Co-authored-by: CalMWolfs <94038482+CalMWolfs@users.noreply.github.com>
@CalMWolfs CalMWolfs added the Soon This Pull Request will be merged within the next couple of betas label May 23, 2024
@hannibal002 hannibal002 requested a review from CalMWolfs May 24, 2024 17:10
@hannibal002 hannibal002 merged commit 6e4a3b7 into hannibal002:beta May 24, 2024
3 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label May 24, 2024
@superhize superhize deleted the flare_timer branch June 17, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalMWolfs CalMWolfs Awaiting requested review from CalMWolfs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.26
Development

Successfully merging this pull request may close these issues.
3 participants
@superhize @CalMWolfs @hannibal002