Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: Enum in GardenCropMilestoneDisplay #1535

Merged
merged 29 commits into from
May 6, 2024

Conversation

hannibal002
Copy link
Owner

Dependencies

What

Use enum rather than ordinals in GardenCropMilestoneDisplay.

Changelog Technical Details

  • Use enum rather than ordinals in GardenCropMilestoneDisplay. - hannibal2

qtlunya and others added 26 commits February 24, 2024 19:35
Co-authored-by: HiZe <superhize@hotmail.com>
Co-authored-by: CalMWolfs <94038482+CalMWolfs@users.noreply.github.com>
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/config/commands/Commands.kt
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/features/garden/farming/GardenCropMilestoneDisplay.kt
#	src/main/java/at/hannibal2/skyhanni/features/misc/discordrpc/DiscordStatus.kt
@hannibal002 hannibal002 added Waiting on Dependency PR waiting for a dependency pr to be merged Backend A backend pull request that will be merged soon labels Apr 24, 2024
@hannibal002 hannibal002 added this to the Version 0.25 milestone Apr 24, 2024
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Apr 24, 2024
@CalMWolfs CalMWolfs self-requested a review April 24, 2024 09:43
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, code between this and your other branch is fine just need the original review comments to be resolved

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label May 1, 2024
Copy link

github-actions bot commented May 1, 2024

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@hannibal002 hannibal002 removed the Waiting on Dependency PR waiting for a dependency pr to be merged label May 3, 2024
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/config/features/garden/cropmilestones/CropMilestonesOverflowConfig.java
#	src/main/java/at/hannibal2/skyhanni/data/GardenCropMilestones.kt
#	src/main/java/at/hannibal2/skyhanni/features/garden/FarmingMilestoneCommand.kt
#	src/main/java/at/hannibal2/skyhanni/features/garden/farming/GardenBestCropTime.kt
#	src/main/java/at/hannibal2/skyhanni/features/garden/farming/GardenCropMilestoneDisplay.kt
#	src/main/java/at/hannibal2/skyhanni/features/garden/inventory/GardenInventoryTooltipOverflow.kt
#	src/main/java/at/hannibal2/skyhanni/features/misc/discordrpc/DiscordStatus.kt
#	src/main/java/at/hannibal2/skyhanni/utils/RenderUtils.kt
Copy link

github-actions bot commented May 4, 2024

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label May 4, 2024
@hannibal002 hannibal002 requested a review from CalMWolfs May 4, 2024 17:36
@hannibal002
Copy link
Owner Author

fixed merge conflicts

@hannibal002 hannibal002 merged commit 026bd1c into beta May 6, 2024
7 checks passed
@hannibal002 hannibal002 deleted the use-enum-rather-than-ordinals branch May 6, 2024 15:30
@github-actions github-actions bot removed Soon This Pull Request will be merged within the next couple of betas Backend A backend pull request that will be merged soon labels May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants