-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backend: Enum in GardenCropMilestoneDisplay #1535
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: HiZe <superhize@hotmail.com>
Co-authored-by: CalMWolfs <94038482+CalMWolfs@users.noreply.github.com>
# Conflicts: # src/main/java/at/hannibal2/skyhanni/config/commands/Commands.kt
# Conflicts: # src/main/java/at/hannibal2/skyhanni/features/garden/farming/GardenCropMilestoneDisplay.kt # src/main/java/at/hannibal2/skyhanni/features/misc/discordrpc/DiscordStatus.kt
hannibal002
added
Waiting on Dependency PR
waiting for a dependency pr to be merged
Backend
A backend pull request that will be merged soon
labels
Apr 24, 2024
hannibal002
added
the
Soon
This Pull Request will be merged within the next couple of betas
label
Apr 24, 2024
CalMWolfs
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again, code between this and your other branch is fine just need the original review comments to be resolved
github-actions
bot
added
the
Merge Conflicts
There are open merge conflicts with the beta branch.
label
May 1, 2024
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
hannibal002
removed
the
Waiting on Dependency PR
waiting for a dependency pr to be merged
label
May 3, 2024
# Conflicts: # src/main/java/at/hannibal2/skyhanni/config/features/garden/cropmilestones/CropMilestonesOverflowConfig.java # src/main/java/at/hannibal2/skyhanni/data/GardenCropMilestones.kt # src/main/java/at/hannibal2/skyhanni/features/garden/FarmingMilestoneCommand.kt # src/main/java/at/hannibal2/skyhanni/features/garden/farming/GardenBestCropTime.kt # src/main/java/at/hannibal2/skyhanni/features/garden/farming/GardenCropMilestoneDisplay.kt # src/main/java/at/hannibal2/skyhanni/features/garden/inventory/GardenInventoryTooltipOverflow.kt # src/main/java/at/hannibal2/skyhanni/features/misc/discordrpc/DiscordStatus.kt # src/main/java/at/hannibal2/skyhanni/utils/RenderUtils.kt
Conflicts have been resolved! 🎉 |
github-actions
bot
removed
the
Merge Conflicts
There are open merge conflicts with the beta branch.
label
May 4, 2024
fixed merge conflicts |
github-actions
bot
removed
Soon
This Pull Request will be merged within the next couple of betas
Backend
A backend pull request that will be merged soon
labels
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies
What
Use enum rather than ordinals in GardenCropMilestoneDisplay.
Changelog Technical Details