-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backend: Add unimined build system #1456
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
Conflicts have been resolved! 🎉 |
85fe85b
to
7bff381
Compare
6053b19
to
940a768
Compare
hannibal002
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reduces build process after one class changed from ~1m5s to 45s for me
hannibal002
added a commit
that referenced
this pull request
Apr 22, 2024
This reverts commit 40309bc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This changes the build system from architectury loom to unimined.
This has some advantages and disadvantages.
For Loom
For Unimined
Migration
In theory the only migration that is needed is to delete the
Minecraft Client
run configuration. It will then regenerate as needed by unimined. It will also allow you to directly use therunClient
gradle task.Motive
The main motive behind this is the individual source set support. This allows us to easier export a public (stable) API to allow other mods to interact with us. Another thing is to limit NEU to only a certain subset of the code. Yet another thing would be to potentially allow breaking out parts of the code into another source set for a sort of "libskyhanni" library that other mods can shade and relocate to jumpstart their mod with rich libraries.
Changelog Technical Details
exclude_from_changelog
since this pr gets reverted with e76b356