Improvement + Fix: Barn Fishing Timer #858
Annotations
10 errors and 1 warning
Check Style:
annotation-processors/src/main/kotlin/at/hannibal2/skyhanni/skyhannimodule/ModuleProcessor.kt#L64
[ktlint] reported by reviewdog 🐶
Exceeded max line length (140)
Raw Output:
annotation-processors/src/main/kotlin/at/hannibal2/skyhanni/skyhannimodule/ModuleProcessor.kt:64:141: error: Exceeded max line length (140) (standard:max-line-length)
|
Check Style:
annotation-processors/src/main/kotlin/at/hannibal2/skyhanni/skyhannimodule/ModuleProcessor.kt#L71
[ktlint] reported by reviewdog 🐶
Exceeded max line length (140)
Raw Output:
annotation-processors/src/main/kotlin/at/hannibal2/skyhanni/skyhannimodule/ModuleProcessor.kt:71:141: error: Exceeded max line length (140) (standard:max-line-length)
|
Check Style:
annotation-processors/src/main/kotlin/at/hannibal2/skyhanni/skyhannimodule/ModuleProcessor.kt#L90
[ktlint] reported by reviewdog 🐶
Exceeded max line length (140)
Raw Output:
annotation-processors/src/main/kotlin/at/hannibal2/skyhanni/skyhannimodule/ModuleProcessor.kt:90:141: error: Exceeded max line length (140) (standard:max-line-length)
|
Check Style:
build.gradle.kts#L47
[ktlint] reported by reviewdog 🐶
Newline expected after opening brace
Raw Output:
build.gradle.kts:47:33: error: Newline expected after opening brace (standard:function-literal)
|
Check Style:
build.gradle.kts#L176
[ktlint] reported by reviewdog 🐶
Expected newline before '.'
Raw Output:
build.gradle.kts:176:58: error: Expected newline before '.' (standard:chain-method-continuation)
|
Check Style:
build.gradle.kts#L215
[ktlint] reported by reviewdog 🐶
Missing trailing comma before ")"
Raw Output:
build.gradle.kts:215:62: error: Missing trailing comma before ")" (standard:trailing-comma-on-call-site)
|
Check Style:
build.gradle.kts#L218
[ktlint] reported by reviewdog 🐶
Redundant curly braces
Raw Output:
build.gradle.kts:218:44: error: Redundant curly braces (standard:string-template)
|
Check Style:
settings.gradle.kts#L23
[ktlint] reported by reviewdog 🐶
Missing spacing after "version"
Raw Output:
settings.gradle.kts:23:67: error: Missing spacing after "version" (standard:op-spacing)
|
Check Style:
src/main/java/at/hannibal2/skyhanni/api/HotmAPI.kt#L28
[ktlint] reported by reviewdog 🐶
Newline expected before operand in multiline condition
Raw Output:
src/main/java/at/hannibal2/skyhanni/api/HotmAPI.kt:28:69: error: Newline expected before operand in multiline condition (standard:condition-wrapping)
|
Check Style
reviewdog: Too many results (annotations) in diff.
You may miss some annotations due to GitHub limitation for annotation created by logging command.
Please check GitHub Actions log console to see all results.
Limitation:
- 10 warning annotations and 10 error annotations per step
- 50 annotations per job (sum of annotations from all the steps)
- 50 annotations per run (separate from the job annotations, these annotations aren't created by users)
Source: https://github.com/orgs/community/discussions/26680#discussioncomment-3252835
|
Check Style
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|