Skip to content

Feat roslyn analyzer support #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
handzlikchris merged 1 commit into from
Apr 23, 2025
Merged

Feat roslyn analyzer support #168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 30 additions & 11 deletions Assets/Scripts/Editor/Compilation/DotnetExeCompilator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
namespace FastScriptReload.Editor.Compilation
{
[InitializeOnLoad]
public class DotnetExeDynamicCompilation: DynamicCompilationBase
public class DotnetExeDynamicCompilation : DynamicCompilationBase
{
private static string _dotnetExePath;
private static string _cscDll;
Expand All @@ -28,25 +28,39 @@ public class DotnetExeDynamicCompilation: DynamicCompilationBase
private static string ApplicationContentsPath = EditorApplication.applicationContentsPath;
private static readonly List<string> _createdFilesToCleanUp = new List<string>();
private static readonly Dictionary<string, Assembly> _typeNameAssemblyCache = new Dictionary<string, Assembly>(16);

private static readonly List<string> _analyzers = new List<string>();
static DotnetExeDynamicCompilation()
{
const string RoslynAnalyzerExtension = ".dll";
const string RoslynAnalyzerKeyword = "RoslynAnalyzer";
#if UNITY_EDITOR_WIN
const string dotnetExecutablePath = "dotnet.exe";
#else
const string dotnetExecutablePath = "dotnet"; //mac and linux, no extension
#endif

_dotnetExePath = FindFileOrThrow(dotnetExecutablePath);
_cscDll = FindFileOrThrow("csc.dll"); //even on mac/linux need to find dll and use, not no extension one
_tempFolder = Path.GetTempPath();


foreach (var guid in AssetDatabase.FindAssets("t: " + nameof(DefaultAsset)))
{
var assetPath = AssetDatabase.GUIDToAssetPath(guid);
if (!assetPath.EndsWith(RoslynAnalyzerExtension)) continue;
var asset = AssetDatabase.LoadAssetAtPath<DefaultAsset>(assetPath);
var assetLabels = AssetDatabase.GetLabels(asset);
if (assetLabels.Contains(RoslynAnalyzerKeyword))
{
_analyzers.Add(Path.GetFullPath(assetPath));
}
}

EditorApplication.playModeStateChanged += obj =>
{
if (obj == PlayModeStateChange.ExitingPlayMode && _createdFilesToCleanUp.Any())
{
LoggerScoped.LogDebug($"Removing temporary files: [{string.Join(",", _createdFilesToCleanUp)}]");

foreach (var fileToCleanup in _createdFilesToCleanUp)
{
new FileInfo(fileToCleanup).IsReadOnly = false;
Expand Down Expand Up @@ -101,15 +115,15 @@ public static CompileResult Compile(List<string> filePathsWithSourceCode, UnityM
out var createInternalVisibleToAsmElapsedMilliseconds);

var shouldAddUnsafeFlag = createSourceCodeCombinedResult.SourceCode.Contains("unsafe"); //TODO: not ideal as 'unsafe' can be part of comment, not code. But compiling with that flag in more cases shouldn't cause issues
var rspFileContent = GenerateCompilerArgsRspFileContents(outLibraryPath, sourceCodeCombinedFilePath, assemblyAttributeFilePath,
var rspFileContent = GenerateCompilerArgsRspFileContents(outLibraryPath, sourceCodeCombinedFilePath, assemblyAttributeFilePath,
originalAssemblyPathToAsmWithInternalsVisibleToCompiled, shouldAddUnsafeFlag);
CreateFileAndTrackAsCleanup(rspFile, rspFileContent, _createdFilesToCleanUp);
CreateFileAndTrackAsCleanup(assemblyAttributeFilePath, DynamicallyCreatedAssemblyAttributeSourceCode, _createdFilesToCleanUp);

var exitCode = ExecuteDotnetExeCompilation(_dotnetExePath, _cscDll, rspFile, outLibraryPath, out var outputMessages);

var compiledAssembly = Assembly.LoadFrom(outLibraryPath);
return new CompileResult(outLibraryPath, outputMessages, exitCode, compiledAssembly, createSourceCodeCombinedResult.SourceCode,
return new CompileResult(outLibraryPath, outputMessages, exitCode, compiledAssembly, createSourceCodeCombinedResult.SourceCode,
sourceCodeCombinedFilePath, createInternalVisibleToAsmElapsedMilliseconds);
}
catch (SourceCodeHasErrorsException e)
Expand All @@ -120,7 +134,7 @@ public static CompileResult Compile(List<string> filePathsWithSourceCode, UnityM
}
catch (Exception e)
{
LoggerScoped.LogError($"Compilation error: temporary files were not removed so they can be inspected: "
LoggerScoped.LogError($"Compilation error: temporary files were not removed so they can be inspected: "
+ string.Join(", ", _createdFilesToCleanUp
.Select(f => $"<a href=\"{f}\" line=\"1\">{f}</a>")));
if (LogHowToFixMessageOnCompilationError)
Expand Down Expand Up @@ -154,7 +168,7 @@ public static CompileResult Compile(List<string> filePathsWithSourceCode, UnityM
*If you want to prevent that message from reappearing please go to Window -> Fast Script Reload -> Start Screen -> Logging -> tick off 'Log how to fix message on compilation error'*");

}

throw new HotReloadCompilationException(e.Message, e, sourceCodeCombinedFilePath);
}
}
Expand Down Expand Up @@ -208,7 +222,7 @@ private static Assembly GetAssemblyByTypeName(string typeName)
return assembly;
}

private static string GenerateCompilerArgsRspFileContents(string outLibraryPath, string sourceCodeCombinedFilePath, string assemblyAttributeFilePath,
private static string GenerateCompilerArgsRspFileContents(string outLibraryPath, string sourceCodeCombinedFilePath, string assemblyAttributeFilePath,
Dictionary<string, string> originalAssemblyPathToAsmWithInternalsVisibleToCompiled, bool addUnsafeFlag)
{
var rspContents = new StringBuilder();
Expand All @@ -233,6 +247,11 @@ private static string GenerateCompilerArgsRspFileContents(string outLibraryPath,
}
}

foreach (var analyzer in _analyzers)
{
rspContents.AppendLine($"-analyzer:\"{analyzer}\"");
}

rspContents.AppendLine($"\"{sourceCodeCombinedFilePath}\"");
rspContents.AppendLine($"\"{assemblyAttributeFilePath}\"");

Expand All @@ -255,7 +274,7 @@ private static string GenerateCompilerArgsRspFileContents(string outLibraryPath,
rspContents.AppendLine("/nowarn:1702");
rspContents.AppendLine("/utf8output");
rspContents.AppendLine("/preferreduilang:en-US");

var rspContentsString = rspContents.ToString();
return rspContentsString;
}
Expand Down