Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant or false throws from tsdocs #748

Merged
merged 1 commit into from
Jul 5, 2021
Merged

Conversation

voodoo11
Copy link
Collaborator

@voodoo11 voodoo11 commented Jul 2, 2021

Context

Functions isItPossible* does not throw NoSheetWithIdError. Instead they return false.

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

Checklist:

  • My code follows the code style of this project,
  • My change requires a change to the documentation,
  • I described the modification in the CHANGELOG.md file.

@voodoo11 voodoo11 requested a review from kirszenbaum July 2, 2021 12:28
@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #748 (ca89ae7) into develop (6d35829) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head ca89ae7 differs from pull request most recent head 0590b96. Consider uploading reports for the commit 0590b96 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #748      +/-   ##
===========================================
- Coverage    92.17%   92.15%   -0.03%     
===========================================
  Files          166      166              
  Lines        40261    39683     -578     
  Branches      5537     5413     -124     
===========================================
- Hits         37111    36569     -542     
+ Misses        3107     3075      -32     
+ Partials        43       39       -4     
Impacted Files Coverage Δ
src/HyperFormula.ts 97.36% <100.00%> (-0.01%) ⬇️
...rc/DependencyGraph/AddressMapping/DenseStrategy.ts 60.91% <0.00%> (-13.71%) ⬇️
src/Matrix.ts 77.04% <0.00%> (-6.96%) ⬇️
src/DependencyGraph/FormulaCellVertex.ts 79.77% <0.00%> (-6.54%) ⬇️
src/interpreter/SimpleRangeValue.ts 84.61% <0.00%> (-6.24%) ⬇️
...Graph/AddressMapping/ChooseAddressMappingPolicy.ts 94.87% <0.00%> (-5.13%) ⬇️
src/DependencyGraph/MatrixMapping.ts 72.72% <0.00%> (-4.76%) ⬇️
src/interpreter/Interpreter.ts 51.42% <0.00%> (-4.58%) ⬇️
src/interpreter/plugin/MatrixPlugin.ts 94.71% <0.00%> (-1.72%) ⬇️
...rc/dependencyTransformers/AddColumnsTransformer.ts 77.16% <0.00%> (-1.58%) ⬇️
... and 39 more

Copy link
Contributor

@wojciechczerniak wojciechczerniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@voodoo11 voodoo11 merged commit 818da05 into develop Jul 5, 2021
@voodoo11 voodoo11 deleted the jk/fix-tsdocs branch July 5, 2021 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants