Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix meta functions dependecies #550

Merged
merged 4 commits into from
Oct 30, 2020
Merged

Fix meta functions dependecies #550

merged 4 commits into from
Oct 30, 2020

Conversation

voodoo11
Copy link
Collaborator

@voodoo11 voodoo11 commented Oct 20, 2020 •
edited by izulin
Loading

Context

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. Dependencies are not correctly collected #549

Checklist:

  • My code follows the code style of this project,
  • My change requires a change to the documentation,
  • I described the modification in the CHANGELOG.md file.

@voodoo11 voodoo11 changed the title Do not ignore references in inner functions of special ones Fix meta functions dependecies Oct 20, 2020
@codecov
Copy link

codecov bot commented Oct 20, 2020 •
edited
Loading

Codecov Report

Merging #550 into develop will decrease coverage by 0.01%.
The diff coverage is 38.09%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #550      +/-   ##
===========================================
- Coverage    91.91%   91.89%   -0.02%     
===========================================
  Files          159      159              
  Lines        31662    31666       +4     
  Branches      2971     2971              
===========================================
- Hits         29101    29099       -2     
- Misses        2555     2561       +6     
  Partials         6        6
Impacted Files Coverage Δ
src/parser/collectDependencies.ts 64.89% <38.09%> (-2.89%) ⬇️
src/interpreter/plugin/FunctionPlugin.ts 84.00% <0.00%> (-0.62%) ⬇️

@izulin izulin requested a review from bardek8 October 29, 2020 10:37
@izulin izulin marked this pull request as ready for review October 29, 2020 10:38
wojciechczerniak
wojciechczerniak approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@wojciechczerniak wojciechczerniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@izulin izulin merged commit ae948ae into develop Oct 30, 2020
@izulin izulin deleted the jk/fix-meta-functions-dependencies branch October 30, 2020 13:56
@wojciechczerniak wojciechczerniak mentioned this pull request Oct 30, 2020
Closed
@doczoidberg
Copy link

please reopen. It is not fixed: #549

@izulin izulin mentioned this pull request Nov 2, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojciechczerniak wojciechczerniak wojciechczerniak approved these changes

@bardek8 bardek8 bardek8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@voodoo11 @doczoidberg @wojciechczerniak @bardek8 @izulin