Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jk/preserve unparsable input #227

Merged
merged 8 commits into from
Mar 6, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unused imports
  • Loading branch information
voodoo11 committed Feb 29, 2020
commit 132dbf56bc329fd234b3fd4aaf395394c7a1675c
4 changes: 2 additions & 2 deletions src/CrudOperations.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {IColumnSearchStrategy} from './ColumnSearch/ColumnSearchStrategy'
import {ColumnsSpan} from './ColumnsSpan'
import {Config} from './Config'
import {ContentChanges} from './ContentChanges'
import {AddressMapping, DependencyGraph, MatrixVertex, ParsingErrorVertex, SheetMapping, ValueCellVertex,} from './DependencyGraph'
import {AddressMapping, DependencyGraph, MatrixVertex, ParsingErrorVertex, SheetMapping, ValueCellVertex} from './DependencyGraph'
import {ValueCellVertexValue} from './DependencyGraph/ValueCellVertex'
import {AddColumnsDependencyTransformer} from './dependencyTransformers/addColumns'
import {AddRowsDependencyTransformer} from './dependencyTransformers/addRows'
Expand Down Expand Up @@ -217,7 +217,7 @@ export class CrudOperations implements IBatchExecutor {
this.columnSearch.change(oldValue, newValue, address)
this.changes.addChange(newValue, address)
} else if (!(vertex instanceof MatrixVertex) && parsedCellContent instanceof CellContent.MatrixFormula) {
const { ast, errors, dependencies } = this.parser.parse(parsedCellContent.formula, address)
const {ast, errors, dependencies} = this.parser.parse(parsedCellContent.formula, address)
if (errors.length > 0) {
this.dependencyGraph.setParsingErrorToCell(address, new ParsingErrorVertex(errors, parsedCellContent.formula))
} else {
Expand Down
4 changes: 2 additions & 2 deletions src/DependencyGraph/ParsingErrorVertex.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {CellError, ErrorType} from '../Cell'
import {buildParsingErrorAst, ParsingError} from '../parser/Ast'
import {CellError} from '../Cell'
import {ParsingError} from '../parser/Ast'

export class ParsingErrorVertex {
constructor(
Expand Down