Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mempool: reject TXs that exceed consensus covenant block limits #768

Merged
merged 2 commits into from
Dec 22, 2022

Conversation

pinheadmz
Copy link
Member

Users have been able to broadcast huge batches with 1,000 OPENs in a single TX. That would make an entire block invalid, so there's no reason to relay such a TX. We could also decide to add a POLICY rule that restricts this even further (the recent wallet batching work limits to like 200)

@coveralls
Copy link

coveralls commented Sep 23, 2022

Coverage Status

Coverage increased (+0.008%) to 68.205% when pulling 2f027e9 on pinheadmz:policy-limits into 455bf60 on handshake-org:master.

@pinheadmz pinheadmz added this to the hsd 5.0.0 milestone Sep 28, 2022
@pinheadmz pinheadmz modified the milestones: hsd 5.0.0, hsd 5.0.1 Nov 29, 2022
Copy link
Contributor

@nodech nodech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find.

I agree, would be nice to have additional policy for mempool/mempoolentry to further limit them if need be.

@nodech nodech added mempool part of the codebase tests part of the codebase enhancement general - improving existing feature patch Release version labels Dec 22, 2022
@nodech nodech modified the milestones: hsd 5.0.1, hsd 5.0.0 Dec 22, 2022
@pinheadmz pinheadmz merged commit bc4a679 into handshake-org:master Dec 22, 2022
pinheadmz added a commit that referenced this pull request Dec 22, 2022
@nodech nodech added breaking-minor Backwards compatible - Release version and removed patch Release version labels Jan 9, 2023
@nodech nodech mentioned this pull request Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-minor Backwards compatible - Release version enhancement general - improving existing feature mempool part of the codebase tests part of the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants