SPV Updates #721
Merged
SPV Updates #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinheadmz
reviewed
May 10, 2022
There was a problem hiding this comment.
LGTM just have a few questions and nits.
If you have time, you could also incorporate bcoin-org/bcoin#755 which should fix all the stuck SPV waiting for new blocks crap and make your tests a lot cleaner.
In addition, I wonder if youd be interested in breaking up the two long test blocks into separate describe for full and SPV and then breaking up the {} blocks as its
Port of bcoin-org/bcoin#755 Co-authored-by: Matthew Zipkin <pinheadmz@gmail.com>
Rename chain-test to chain-full-test. Rename chain-reorg-test to chain-test.
pinheadmz
reviewed
May 13, 2022
|
Synced SPV node from this branch in < 30 minutes. No reorgs while syncing but hey, nice performance. |
nodech
added
breaking-minor
nodech
force-pushed
the
spv-reorg
branch
2 times, most recently
from
2c0507f
to
5513832
Compare
pinheadmz
approved these changes
May 16, 2022
There was a problem hiding this comment.
ACK 5513832
Show Signature
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
ACK 55138329613eec257dff0356f681820f74168e94
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEE5hdzzW4BBA4vG9eM5+KYS2KJyToFAmKCnkEACgkQ5+KYS2KJ
yTrEKA/8DpLKGZf5uIJjBwNhOyU8blxAhNF10zujNrbA8dtsrO5Rf6tOQWAm91nt
ryQftvzFyZPRj4i1Zq3sd/NJnS4CGBThlegretU47LdVDrOCjw5Z4o+AYIVd79es
rA2qsV2X39KjgY52zqgtvn5zsIvfkghzOp1vPx9QFHQutt2au364LEkId5LI8vsZ
laJRkNrlwm71Wk4pRnG+TaqB5V3g5VfB0TT/2OV912pkr/L7ze5xjseVcLk6fplK
J5PnWYnMyCNPJ4UhsP7UhHW2ShSzHvfWP1WPFg4e8zvKu0Pe9962/KgYfAwhH+23
w2I5KvhRoVwGwP0Y7hz7RUvcQ9iDvU77dEcjorRvv95lK9/LBLORthDHUaJgHEY2
5P75MMWm6eQi5gDInO3yXrtg7dTLbif5aI3vVc0kq3nyDdAbpa9/TzDDper784pV
AuIuIzuO1zYSY7YP2NxedKreAlVqkVlW1fzN1s/F3L7JFC8CWu91FGnGFTsMZ3q0
Ma0YBkzcriLuAy0e6UycSTm3cehlT/JMZxICnJTbiqVffhhg+bJldfx7kQ9DFyZe
pP2At9OcyoFLAEK6mJBi0a4/yBm/CTJ2yB5pnMsIsQ8+MKlo/cmatr4GxGxdhvJi
SdLQODYBpWbk+vn324z8xutUYWjNYXUIvepBnfv8xK1F8QCJptQ=
=0rME
-----END PGP SIGNATURE-----
pinheadmz's public key is on keybase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add reorg tests for Chain Full and SPV.
reset.forkentry in thereorganizeevent aftertipandcomptetitor.mtpandtime-too-newchecks to the SPV Chain.