Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update blgr #436

Closed
wants to merge 1 commit into from
Closed

deps: update blgr #436

wants to merge 1 commit into from

Conversation

tynes
Copy link
Contributor

@tynes tynes commented Apr 22, 2020

This pull request updates the blgr dependency so that it includes bcoin-org/blgr#5.

This is very important for usage, as it enables printing of the error stack for any logger.error messages. It will make it much easier to remotely debug with users.

I opened an issue in bcoin/blgr about doing a new release here:
bcoin-org/blgr#9

For now, I am using a fork of bcoin/blgr as part of this pull request and I'm happy to use the bcoin/blgr repo once there is a new release.
https://github.com/Handshake-Protocol/blgr

For users that are currently having trouble, you can run this updated code with the commands:

$ git clone https://github.com/tynes/hsd
$ cd hsd
$ git checkout update-blgr
$ npm i
$ ./bin/hsd --log-level error

Running with --log-level error will only print the error messages, so if you would like to still the the info and debug messages, use --log-level spam.

@tynes
Copy link
Contributor Author

tynes commented Apr 22, 2020

The CI failed, it cannot find blgr. I recall there being some issue about CircleCI not correctly installing dependencies from github, it did work locally though. Will look for the fix when I have some time.

@tynes tynes force-pushed the update-blgr branch 4 times, most recently from 20003c2 to 4fbb9b7 Compare April 27, 2020 22:54
@pinheadmz
Copy link
Member

I agree this is an important upgrade but I don't think we should fork from @chjj / bcoin-org blgr just yet. All the hsd dependencies are knot together and upgraded in sync with bcrypto releases, etc. I'm just going to keep bugging JJ to merge and release the log file rotation in blgr

@pinheadmz pinheadmz closed this Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants