dns/resource: onion{ng} dnssec #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boymanjor
reviewed
Oct 31, 2019
Resource.toA and toAAAA will also add TXT records to the response. This PR adds RRSIG records to the response that authenticate the Onion and OnionNG records.
tynes
force-pushed
the
fix-record-sigs
branch
from
a09a6d3
to
91f1c27
Compare
Codecov Report
@@ Coverage Diff @@
## master #292 +/- ##
==========================================
- Coverage 54.87% 54.87% -0.01%
==========================================
Files 129 129
Lines 35782 35786 +4
Branches 6030 6032 +2
==========================================
+ Hits 19634 19636 +2
- Misses 16148 16150 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resource.toA and toAAAA will also add
TXT records to the response. This will
authenticate the Onion and OnionNG records.
Addresses comment #265 (comment)