net: remove discoverExternal() from the pool #212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the discover external check in the pool. Currently we already store all local addresses that are sent to us from peers in the hostlist, so there is no reason to rely on an external service to check for our local/external address. This was removed from bitcoin in commit 845c86d.
|
ping @pinheadmz, going to add the "discover/discoverable" config in a different pr so its cleaner. |
Codecov Report
@@ Coverage Diff @@
## master #212 +/- ##
==========================================
+ Coverage 52.99% 53.01% +0.02%
==========================================
Files 129 129
Lines 35773 35750 -23
Branches 6032 6027 -5
==========================================
- Hits 18957 18952 -5
+ Misses 16816 16798 -18
Continue to review full report at Codecov.
|
|
utACK. This function hasn’t really worked in a while anyway: |
|
utACK. Has there been discussion around this potentially leaking information about people running nodes? Probably don't want extra external API calls that the user is not necessarily aware of. |
|
@tynes plenty of discussion in bitcoin core. Especially when it got funny: bitcoin/bitcoin#4679 |
nodech
added
net/p2p
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the discover external check in the pool. Currently
we already store all local addresses that are sent to us from peers in
the hostlist, so there is no reason to rely on an external service to
check for our local/external address. This was removed from bitcoin in
commit 845c86d.
EDIT: This is blocked by implementing the saving of local addresses via the remote property in the version packet.