-
Notifications
You must be signed in to change notification settings - Fork 75
Tweaks to add remote selenium driver #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
), "Instruction output file must be a YAML or JSON file or None." | ||
assert ( | ||
chromedriver_path is not None | ||
(chromedriver_path is not None) or (remote_url is not None) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably have to check if it's one or the other, right?
I think it looks mostly good to me, except the one nit on the assertion. I'll have to test it myself some time—I didn't know you could do this with Selenium!—but otherwise thank you for the contribution and I'll try to merge it quickly. |
Hold up. Keep this in pull. I see a few issues that I'd like to fix before merging |
All good now. Tested with my workflow. If you guys want to test Selenium Remote Driver
Calling the agent def run_agent(instructions, config_arguements):
agent = GPTSeleniumAgent(instructions,
remote_url=http://localhost:4444,
user_data_dir=config_arguements.user_data_dir,
headless=True)
agent.run() |
Yeah maintaining selenium, chrome, and chromedriver is a pain. This is easier to just fireoff and run from a remote location. Would appreciate a merge soonish to simplify my package mangement |
Taking a look now. |
Hey @rapatel0 I tried this and got the following error: Once I can replicate it working then I'll merge and update the package. EDIT: Ah, I think it's because the docker container did not work. It can't detect my platform (linux/arm64/v8). Will keep trying... EDIT2: Fixed this using the seleniarm distribution. Now getting this error, if you can help: EDIT3: This link helped. |
Thanks @rapatel0, just updated the package. 0.2.51. Appreciate the update, this was cool to try out. |
The changes enable usage of
driver.remote()
in selenium for remote execution.