-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented credibility_interval() #188
Open
Stefan-Heimersheim
wants to merge
89
commits into
handley-lab:master
Choose a base branch
from
Stefan-Heimersheim:credibility-interval
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 77 commits
Commits
Show all changes
89 commits
Select commit
Hold shift + click to select a range
00c61e5
Implemented Samples.credibility_interval
8098bfd
Improve documentation
f6afe0a
Formatting / make flake8 happy
6c816eb
pydocstyle compliance
e3c1f21
Fix typo made while flake8-ing
c22e304
Merge branch 'williamjameshandley:master' into credibility-interval
Stefan-Heimersheim 3f8f2cb
Merge branch 'master' into credibility-interval
williamjameshandley a39c038
That will teach me to try and use github to manually merge
williamjameshandley be0eb50
Move credibility_interval to utils
3b20f1c
Formatting
4a66d74
flake8 wants def rather than lambda
0d53bce
Remove unneeded variable
d6b8bb9
Remove imports no longer needed
da7ebaf
docstring format
92f24be
Updated CI checks to be in line with github requirements
williamjameshandley 19b3e1a
Moving to full coverage
williamjameshandley e97526e
Added a link to the fastCL repo
williamjameshandley 12a6bc8
Unified quantiles, cdfs and credibility-intervals
williamjameshandley bcf2ae1
Added some CDF tests
williamjameshandley 095a64a
Merge branch 'master' into credibility-interval
williamjameshandley cf95f46
Merge branch 'master' into credibility-interval
williamjameshandley 7f56e78
Merge branch 'master' into credibility-interval
lukashergt d9c4076
Merge branch 'master' into credibility-interval
lukashergt 25e3843
Merge branch 'master' into credibility-interval
lukashergt 693abef
Implemented compress_weights-based credibility_interval with uncertai…
f6e9b40
Merge remote-tracking branch 'upstream/master' into credibility-interval
7d634b5
Remove cdf() function and quantile changes
f33decf
Implement covariance and clean up code
0b938e1
Fix indexing
3d26a41
Update tests
e5cb4b6
flake8 compliance
30c70bf
Merge branch 'master' into credibility-interval
36c58d2
Merge branch 'master' into credibility-interval
lukashergt 4f79a09
version bump from 2.0.0-beta.28 to 2.0.0-beta.29
lukashergt dccfe4b
fix docstring formatting of `utils.credibility_interval`
lukashergt 84ed5b6
Add tests for other methods
d1aaf02
Added tests for compress_samples
2527895
Updated docstring
b466d1a
Removed u kw argument
0d59b7c
n_iter to nsamples
2a0d3b8
Added CDF fill_value; added tests
ed4607f
Typo
b4b78e6
Renamed methods to full names
9911dd2
flake8 compatibility
5ac5fca
Implemented Samples.credibility_interval
86d3836
flake8 compatibility
dbd1303
Implemented suggestions
7ce8b59
Improved tests with Lukas' suggestions
f016fa5
Improve tests
fb42c59
bump version number to 2.0.0b30
lukashergt 5c14599
Merge branch 'master' into credibility-interval
lukashergt 1997ffd
Update _version.py
lukashergt b0862e1
Merge branch 'master' into credibility-interval
lukashergt a92f822
Update _version.py
lukashergt 4d16340
Update README.rst
lukashergt 1e78eb7
Merge branch 'master' into credibility-interval
lukashergt 7fdd99a
remove `verbose` kwarg which is now unused
lukashergt 8a44f17
remove also docstring of `verbose` kwarg
lukashergt 1327055
rewrite `credibility_interval` _method_ to automatically do all DataF…
lukashergt 16a0d42
version bump to 2.0.0-beta.35
lukashergt 49a3d1b
version bump to 2.0.0-beta.36
lukashergt 48444c4
Merge branch 'master' into credibility-interval
lukashergt d1cdd8c
fix flake8: blank line contains whitespace
lukashergt f641a40
Merge branch 'master' into credibility-interval
lukashergt 5fb72f1
version bump to 2.0.0b37
lukashergt bad654c
update from `ncompress=-1` to `ncompress='equal'`
lukashergt 26ce56a
Merge branch 'master' into credibility-interval
lukashergt 39337dc
update another instance of `ncompress=-1` to `ncompress='equal'`
lukashergt 010a02e
implement `return_covariance` option for lower-limit and upper-limit …
lukashergt f05f3fd
update `test_credibility_interval` to new dataframe return values
lukashergt f1e4d11
Merge branch 'master' into credibility-interval
williamjameshandley 707376b
Merge branch 'master' into credibility-interval
lukashergt 463ae88
Merge branch 'master' into credibility-interval
williamjameshandley 49863cc
newline
williamjameshandley 1ec5b8e
move `credibility_interval` method from `samples.py` to `weighted_pan…
lukashergt 0c63e6e
add tests for Series method of `credibility_interval`
lukashergt 54bf848
Merge branch 'master' into credibility-interval
lukashergt 292aba5
Merge branch 'master' into credibility-interval
lukashergt b85b84d
Merge branch 'master' into credibility-interval
williamjameshandley 525381c
Merge branch 'master' into credibility-interval
williamjameshandley 9fabe8d
Remove unnecessary assertion
3da3115
Merge branch 'master' into credibility-interval
lukashergt 56a0c6c
version bump to 2.3.0
lukashergt 8aa2bb8
Merge branch 'master' into credibility-interval
lukashergt 5832781
Merge branch 'master' into credibility-interval
lukashergt 48b1a8b
version bump to 2.4.0
lukashergt 202d754
Merge branch 'master' into credibility-interval
lukashergt fe25aeb
version bump to 2.5.0
lukashergt 3e6bd4b
Merge branch 'master' into credibility-interval
williamjameshandley File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
__version__ = '2.1.2' | ||
__version__ = '2.2.0' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be more appropriate to normalise as follows?
Or would it be better to handle bound errors within
interp1d
? (see below)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly it doesn't matter since
atol=1e-9
, this is just dealing with python float precision. So lets stick to the simpler version to avoid looking like we're doing some actual normalisationThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would strongly prefer for there not to be an assert statement (which the normalisation would fix). This kind of thing would be infuriating as part of a large automated pipeline where floating point errors derail a larger workflow.