Allow consumers to update DOM asynchronously for certain transactions#270
Merged
Conversation
angelaguo
changed the title
smoores-dev
approved these changes
Jul 10, 2026
juliebarwick
added a commit
to gamma-app/y-prosemirror
that referenced
this pull request
Jul 10, 2026
Set metadata on yCursorPlugin transactions to tell react-prosemirror to skip flushSync for them. (Corresponding functionality added to react-prosemirror [here](handlewithcarecollective/react-prosemirror#270)). These transactions are consistently firing in between DOM selection updates and the browser firing the corresponding selectionchange event, which is causing selection reversions in Gamma
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide a mechanism for consumers to skip flushSync on certain transactions - if a transaction has
asyncset to true in its meta, do notflushSyncindispatchTransaction