Fixing #1673 #1674

ErisDS · 2020-04-03T18:51:06Z

Note, I've deliberately commented out a bunch of tests just to make it a little easier to see what is failing

added a test to demonstrate the regression
use duplicate-arguments-array, which correctly handles --amd --no-amd
unfortunately this breaks all other valid multi-keys like -k for known helpers :(

- demonstrates the regression

fixes handlebars-lang#1673 - we no longer need to pin to yargs 14 for node 6 & 8 support

ErisDS changed the title ~~Attempt to fix #1673~~ [Failed] Attempt to fix #1673 Apr 3, 2020

ErisDS mentioned this pull request Apr 3, 2020

Regression in the command line parsing #1673

Closed

ErisDS added 2 commits April 3, 2020 20:41

tests: added failing test for issue handlebars-lang#1673

0adc63d

- demonstrates the regression

chore: bumping yargs to v15

b9e905b

fixes handlebars-lang#1673 - we no longer need to pin to yargs 14 for node 6 & 8 support

ErisDS force-pushed the issue-1673 branch from 65d308d to b9e905b Compare April 3, 2020 19:43

ErisDS changed the title ~~[Failed] Attempt to fix #1673~~ Fixing #1673 Apr 3, 2020

ErisDS merged commit 8727d20 into handlebars-lang:master Apr 3, 2020

ErisDS deleted the issue-1673 branch April 3, 2020 20:03

Provide feedback