Skip to content

Conversation

MichalBryxi
Copy link

@MichalBryxi MichalBryxi commented Apr 15, 2025

Somewhere between v2.1.0 and v2.2.0 this package started having issues with ember-cli-addon-docs. This patch fixes that.

Fixes: #20

With this change I can remove the override from ember-intls pakcage.json:

   "pnpm": {
     "overrides": {
-      "ember-cli-addon-docs>@handlebars/parser": "2.1.0"
+      "ember-cli-addon-docs": "file:../ember-cli-addon-docs", // points to `v2.2.0` version of the addon
+      "ember-cli-addon-docs>@handlebars/parser": "file:../handlebars-parser" // points to my fix
     }
   }

And ember-intl addon docs boot up correctly.

Copy link
Contributor

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing type=module changes the interpretation of .js

instead, you may want to change the build to emit cjs for the package.json#exports require condition

it looks like those files don't end in .cjs, as they should.

but more importantly, what error are you trying to fix?

@MichalBryxi
Copy link
Author

but more importantly, what error are you trying to fix?

Repro is in ember-cli-addon-docs: ember-learn/ember-cli-addon-docs#1669

@MichalBryxi
Copy link
Author

MichalBryxi commented Apr 17, 2025

After the discussion with @NullVoxPopuli, I think the most productive path that wastes least amount of time would be to document the node requirements and move on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

require() of ES Module ... not supported when using ember-cli-addon-docs

2 participants