Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json-serde: streaming md5 #382

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mateusz834
Copy link

@mateusz834 mateusz834 commented Apr 5, 2023

(for canada 100)

Before:

User time (seconds): 3.61
Maximum resident set size (kbytes): 542020

After:

User time (seconds): 3.45
Maximum resident set size (kbytes): 114816

@hanabi1224
Copy link
Owner

Thanks for the PR! It's a great optimization, but I think it makes the zig solution incomparable to others, I might need more time to think about it.

@mateusz834
Copy link
Author

mateusz834 commented Apr 13, 2023

How about 2-streaming.zig ? I also added streaming md5 for go and rust. (go doesn't have any performance improvements, it buffers the entire json before writing) and added error handling for the go code.

@mateusz834 mateusz834 changed the title json-serde zig: streaming md5 json-serde: streaming md5 Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants